Conversation
Member
Author
|
Note: I know bumping MSRV to a Rust version released today is aggressive, but I'm not in any hurry to release any of these crates. I think it'd be good to spend time making sure This repo is sort of an integration capstone for all of the crates, so I expect it will take awhile to sort all of the above out, by which point Rust 1.50 may be out and Rust 1.49 will seem less onerous. |
eed9ffe to
651f6cb
Compare
The `aes` crate is a key component of several crates in this repo, and just had an MSRV breaking change in RustCrypto/block-ciphers#216. This commit bumps the MSRV of all crates in this repo which use the `aes` crate to MSRV 1.49+. In the case of `aes-gcm` and `aes-gcm-siv` specifically, the changes in RustCrypto/universal-hashes#113 bumped the MSRV of `ghash` and `polyval` to 1.49+ as well, so there are multiple motivations for this new MSRV.
651f6cb to
2f76aae
Compare
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 84.97% 85.15% +0.17%
==========================================
Files 31 31
Lines 1118 1118
==========================================
+ Hits 950 952 +2
+ Misses 168 166 -2
Continue to review full report at Codecov.
|
tarcieri
added a commit
that referenced
this pull request
Jan 2, 2021
Like we did with the `aes` crate in #252, this bumps the `chacha20` crate to a version which implements runtime CPU feature detection (AVX2/SSE2) and uses new support for `ManuallyDrop` union fields which became available in Rust 1.49.
tarcieri
added a commit
that referenced
this pull request
Jan 2, 2021
Like we did with the `aes` crate in #252, this bumps the `chacha20` crate to a version which implements runtime CPU feature detection (AVX2/SSE2) and uses new support for `ManuallyDrop` union fields which became available in Rust 1.49.
tarcieri
added a commit
that referenced
this pull request
Jan 2, 2021
Like we did with the `aes` crate in #252, this bumps the `chacha20` crate to a version which implements runtime CPU feature detection (AVX2/SSE2) and uses new support for `ManuallyDrop` union fields which became available in Rust 1.49.
tarcieri
added a commit
that referenced
this pull request
Jan 2, 2021
Like we did with the `aes` crate in #252, this bumps the `chacha20` crate to a version which implements runtime CPU feature detection (AVX2/SSE2) and uses new support for `ManuallyDrop` union fields which became available in Rust 1.49.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
aescrate is a key component of several crates in this repo, and just had an MSRV breaking change in RustCrypto/block-ciphers#216.This commit bumps the MSRV of all crates in this repo which use the
aescrate to MSRV 1.49+.In the case of
aes-gcmandaes-gcm-sivspecifically, the changes in RustCrypto/universal-hashes#113 bumped the MSRV ofghashandpolyvalto 1.49+ as well, so there are multiple motivations for this new MSRV.