password-hash: impl From<phc::Error> for Error#2124
Merged
Conversation
This is useful within the impls of traits like `PasswordHasher` where the return type is `password_hash::Result<phc::PasswordHash>` but various `phc::Error`s may occur when constructing the `PasswordHash` from the params, salt, and output
Merged
tarcieri
added a commit
that referenced
this pull request
Mar 10, 2026
## Added - Generic `H` param to traits to support multiple string formats e.g. PHC, MCF (#2110) - Implement `From<phc::Error>` for `Error` (#2124) - `rand_core` feature (#2126) - Salt generating helper functions `(try_)generate_salt` (#2128) - `Error::RngFailure` variant (#2337) ## Changed - Edition changed to 2024 and MSRV bumped to 1.85 (#1759) - Extract `CustomizedPasswordHasher` trait (#2105) - Bump `getrandom` to v0.4 (#2258) ## Removed - `Encoding` enum (#2102) - PHC types moved to the `phc` crate, which is re-exported as `password_hash::phc` when the `phc` crate feature is enabled (#2103, #2116): - `Ident` - `Output` - `ParamsString` - `PasswordHash` - `PasswordHashString` - `Salt` - `SaltString` - `Value` - `McfHasher` trait (#2334)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful within the impls of traits like
PasswordHasherwhere the return type ispassword_hash::Result<phc::PasswordHash>but variousphc::Errors may occur when constructing thePasswordHashfrom the params, salt, and output