password-hash: add generic H param to traits#2110
Merged
Conversation
Adds a generic `H` parameter to the `(Customized)PasswordHasher` and `PasswordVerifier` traits which specifies the return type and the hash type respectively. A generic parameter is used instead of an associated constant in order to support overlapping impls. Notably multiple commonly used password hashing algorithms (e.g. PBKDF2, scrypt) support encoding in either the Modular Crypt Format (MCF) or Password Hashing Competition (PHC) string format, which are implemented as the `mcf::PasswordHash` and `phc::PasswordHash` types respectively. We already have open issues to add MCF support where we currently don't support it (RustCrypto/password-hashes#727, RustCrypto/password-hashes#747). The blanket impl of `PasswordVerifier` for `CustomizedPasswordHasher` is retained, but only for `phc::PasswordHash`, as supporting it for MCF requires algorithmic-specific interpretation of the hash. However, algorithms can provide their own impls of `PasswordVerifier<mcf::PasswordHash>`.
Member
Author
|
Note: this almost completely decouples |
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 7, 2025
Companion PR to RustCrypto/traits#2110
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 7, 2025
Companion PR to RustCrypto/traits#2110
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 7, 2025
Companion PR to RustCrypto/traits#2110
Merged
tarcieri
added a commit
that referenced
this pull request
Mar 10, 2026
## Added - Generic `H` param to traits to support multiple string formats e.g. PHC, MCF (#2110) - Implement `From<phc::Error>` for `Error` (#2124) - `rand_core` feature (#2126) - Salt generating helper functions `(try_)generate_salt` (#2128) - `Error::RngFailure` variant (#2337) ## Changed - Edition changed to 2024 and MSRV bumped to 1.85 (#1759) - Extract `CustomizedPasswordHasher` trait (#2105) - Bump `getrandom` to v0.4 (#2258) ## Removed - `Encoding` enum (#2102) - PHC types moved to the `phc` crate, which is re-exported as `password_hash::phc` when the `phc` crate feature is enabled (#2103, #2116): - `Ident` - `Output` - `ParamsString` - `PasswordHash` - `PasswordHashString` - `Salt` - `SaltString` - `Value` - `McfHasher` trait (#2334)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generic
Hparameter to the(Customized)PasswordHasherandPasswordVerifiertraits which specifies the return type and the hash type respectively.A generic parameter is used instead of an associated constant in order to support overlapping impls. Notably multiple commonly used password hashing algorithms (e.g. PBKDF2, scrypt) support encoding in either the Modular Crypt Format (MCF) or Password Hashing Competition (PHC) string format, which are implemented as the
mcf::PasswordHashandphc::PasswordHashtypes respectively.We already have open issues to add MCF support where we currently don't support it (RustCrypto/password-hashes#727,
RustCrypto/password-hashes#747).
The blanket impl of
PasswordVerifierforCustomizedPasswordHasheris retained, but only forphc::PasswordHash, as supporting it for MCF requires algorithmic-specific interpretation of the hash. However, algorithms can provide their own impls ofPasswordVerifier<mcf::PasswordHash>.