pkcs1+sec1: remove pkcs8 integration/feature#1927
Merged
Conversation
Member
Author
|
This will need a companion PR to the |
c8db792 to
7c1f9f4
Compare
tarcieri
added a commit
to RustCrypto/RSA
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the PKCS#1 impl
tarcieri
added a commit
to RustCrypto/RSA
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the PKCS#1 impl
tarcieri
added a commit
to RustCrypto/RSA
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the PKCS#1 impl
7c1f9f4 to
ed1ad95
Compare
tarcieri
added a commit
to RustCrypto/RSA
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the PKCS#1 impl
Both `pkcs1` and `sec1` used some "clever" tricks to write blanket impls of their traits for any types which impl the `pkcs8` traits. However, we've received some complaints this makes the impls of these traits more confusing and less discoverable (#1611), and adds a maintenance burden in that the blanket impl relationship is fundamentally "backwards" in that PKCS#8 builds on PKCS#1 and SEC1, not the other way around. These could potentially be replaced with a macro that writes impls of the `pkcs8` traits for types which impl the `pkcs1`/`sec1` traits. However, for now, each of these is only used in one place (i.e. the `rsa` and `elliptic-curve` crates respectively), so we can start by moving the relevant code there for now.
ed1ad95 to
ecb6713
Compare
tarcieri
added a commit
to RustCrypto/RSA
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the PKCS#1 impl
tarcieri
added a commit
that referenced
this pull request
Jul 10, 2025
tarcieri
added a commit
to RustCrypto/RSA
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the PKCS#1 impl
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the SEC1 impl
tarcieri
added a commit
to RustCrypto/RSA
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the PKCS#1 impl
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the SEC1 impl
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the SEC1 impl
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Jul 10, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the SEC1 impl
pinkforest
pushed a commit
to pinkforest/RSA
that referenced
this pull request
Aug 22, 2025
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the PKCS#1 impl
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
Companion PR to RustCrypto/formats#1927 which properly composes the PKCS#8 impl in terms of the PKCS#1 impl
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
pkcs1andsec1used some "clever" tricks to write blanket impls of their traits for any types which impl thepkcs8traits.However, we've received some complaints this makes the impls of these traits more confusing and less discoverable (#1611), and adds a maintenance burden in that the blanket impl relationship is fundamentally "backwards" in that PKCS#8 builds on PKCS#1 and SEC1, not the other way around.
These could potentially be replaced with a macro that writes impls of the
pkcs8traits for types which impl thepkcs1/sec1traits. However, for now, each of these is only used in one place (i.e. thersaandelliptic-curvecrates respectively), so we can start by moving the relevant code there for now.