Gate PKCS#1/PKCS#8 support on encoding feature#537
Merged
Conversation
6958327 to
bf6e33c
Compare
Support for these formats has a number of dependencies required, and isn't always necessary, e.g. the `ssh-key` crate implements an entirely different encoding format for RSA keys. Making support an optional feature avoids incurring these dependencies when that's the case. This commit also removes the `pem` feature and makes PEM support on-by-default whenever `encoding` is enabled. This only adds the `pem-rfc7468` dependency. Most users will probably want PEM support if they have the `encoding` feature enabled.
bf6e33c to
009a47e
Compare
Member
Author
|
Going to merge this so I can work on RustCrypto/formats#1927 |
pinkforest
pushed a commit
to pinkforest/RSA
that referenced
this pull request
Aug 22, 2025
Support for these formats has a number of dependencies required, and isn't always necessary, e.g. the `ssh-key` crate implements an entirely different encoding format for RSA keys. Making support an optional feature avoids incurring these dependencies when that's the case. This commit also removes the `pem` feature and makes PEM support on-by-default whenever `encoding` is enabled. This only adds the `pem-rfc7468` dependency. Most users will probably want PEM support if they have the `encoding` feature enabled.
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
Support for these formats has a number of dependencies required, and isn't always necessary, e.g. the `ssh-key` crate implements an entirely different encoding format for RSA keys. Making support an optional feature avoids incurring these dependencies when that's the case. This commit also removes the `pem` feature and makes PEM support on-by-default whenever `encoding` is enabled. This only adds the `pem-rfc7468` dependency. Most users will probably want PEM support if they have the `encoding` feature enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for these formats has a number of dependencies required, and isn't always necessary, e.g. the
ssh-keycrate implements an entirely different encoding format for RSA keys.Making support an optional feature avoids incurring these dependencies when that's the case.
This commit also removes the
pemfeature and makes PEM support on-by-default wheneverencodingis enabled. This only adds thepem-rfc7468dependency. Most users will probably want PEM support if they have theencodingfeature enabled.