regression: room list not using full sidebar width in new navigation#35454
Conversation
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
|
Looks like this PR is ready to merge! 🎉 |
|
|
I have not added changeset, since the issue is not present in the previous version. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35454 +/- ##
===========================================
+ Coverage 59.64% 59.68% +0.03%
===========================================
Files 2828 2829 +1
Lines 68542 68790 +248
Branches 15193 15238 +45
===========================================
+ Hits 40884 41056 +172
- Misses 25010 25075 +65
- Partials 2648 2659 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dougfabris
left a comment
There was a problem hiding this comment.
Its not a fix since this bug wasn't shipped in any version. Let's use regression for that!
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
dougfabris
left a comment
There was a problem hiding this comment.
Thanks for the very quick fix 👍
Proposed changes (including videos or screenshots)
This PR fixes an issue where the room list in the new navigation was not occupying full of the sidebar width.
Introduced here: #33796
Before

After
Occupies full width
Issue(s)
Steps to test or reproduce
Further comments
CORE-1016