feat: Replace rc-scrollbars in favor of overlayscrollbars#33796
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: df52273 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33796 +/- ##
===========================================
- Coverage 59.46% 59.43% -0.03%
===========================================
Files 2830 2828 -2
Lines 68512 68200 -312
Branches 15163 15100 -63
===========================================
- Hits 40744 40538 -206
+ Misses 25107 25014 -93
+ Partials 2661 2648 -13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1bd09a3 to
2624f09
Compare
rc-scrollbars in favor of overlayscrollbars
7092d5f to
1e2775b
Compare
MartinSchoeler
approved these changes
Mar 7, 2025
This was referenced Mar 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Our current custom scrollbars doesn't have support to RTL. So this PR aims to replace the usage of
rc-scrollbarsin favor ofoverlayScrollbarswhich does support. So doing it we'll be able to fix some a11y when using RTL languagesTO-DO
rc-scrollbarsrc-scrollbarsCSS codeRoomHistoryManagerwill work removing the.rc-scrollbars-viewclassuseLegacyThreadMessageListScrollingwill work properly when replacing theScrollValuestypeCustomScrollbarsBefore
After
It also fixes such small annoying visual issues:
Issue(s)
Closes #30564
Closes #30095
Closes #29359
Steps to test or reproduce
Further comments
CORE-1008