This repository was archived by the owner on Jun 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 552
[IMPROVEMENT][LAYOUT] Profile Layout according to a web interface #2080
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
345d5cf
Remove dark background from profile EditText
arthurbdiniz 4ff269e
Create header text of edittext and it style
arthurbdiniz f1065cd
Add hint text for username, name and email
arthurbdiniz ea3e05f
Simplify profile EditText xml with style
arthurbdiniz 4f790f3
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat.Android i…
philipbrito b8ba909
Add TODOS.
philipbrito 0a7999c
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat.Android i…
philipbrito fd6f5d9
Update fragment_profile.xml
philipbrito 22d7bf0
Update app version.
philipbrito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -262,7 +262,18 @@ | |
|
|
||
| // REMARK: To be removed. | ||
| <style name="Profile.EditText" parent="Authentication.EditText.Border"> | ||
| <item name="android:background">@drawable/style_edit_text_profile</item> | ||
| <item name="android:layout_height">48dp</item> | ||
| <item name="android:layout_marginTop">8dp</item> | ||
| </style> | ||
|
|
||
| <style name="Profile.TextView" parent="TextAppearance.AppCompat.Title"> | ||
| <item name="android:textSize">16sp</item> | ||
| <item name="android:fontFamily">sans-serif-medium</item> | ||
| <item name="android:textStyle">normal</item> | ||
| <item name="android:layout_marginTop">24dp</item> | ||
| <item name="android:layout_gravity">left</item> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the catch @HusseinElFeky! Changed! |
||
| <item name="android:textColor">@color/colorPrimary</item> | ||
| <item name="android:maxLines">1</item> | ||
| </style> | ||
|
|
||
| <style name="ActionModeStyle" parent="ThemeOverlay.AppCompat.Dark.ActionBar"> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't declare a translatable string as not translatable, please.