This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[IMPROVEMENT][LAYOUT] Profile Layout according to a web interface #2080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Diniz <[email protected]>
Signed-off-by: Arthur Diniz <[email protected]>
Signed-off-by: Arthur Diniz <[email protected]>
Signed-off-by: Arthur Diniz <[email protected]>
philipbrito
suggested changes
May 15, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="msg_profile_update_successfully">Profile update successfully</string> | ||
| <string name="msg_username">username</string> | ||
| <string name="msg_username">Username</string> | ||
| <string name="msg_profile_username_hint" translatable="false">Please enter your username…</string> |
Contributor
There was a problem hiding this comment.
Don't declare a translatable string as not translatable, please.
| <string name="msg_username_or_email">Username or email</string> | ||
| <string name="msg_password">Password</string> | ||
| <string name="msg_name">Name</string> | ||
| <string name="msg_profile_name_hint" translatable="false">Please enter your name…</string> |
Contributor
There was a problem hiding this comment.
Don't declare a translatable string as not translatable, please.
app/src/main/res/values/strings.xml
Outdated
| <string name="msg_name">Name</string> | ||
| <string name="msg_profile_name_hint" translatable="false">Please enter your name…</string> | ||
| <string name="msg_email">Email</string> | ||
| <string name="msg_profile_email_hint" translatable="false">Please enter your email address…</string> |
Contributor
There was a problem hiding this comment.
Don't declare a translatable string as not translatable, please.
philipbrito
suggested changes
May 15, 2019
app/src/main/res/values/strings.xml
Outdated
| ======= | ||
| <string name="msg_profile_updated_successfully">Profile updated successfully</string> | ||
| <string name="msg_username">username</string> | ||
| >>>>>>> dd938089e9ef495da5a5afd57651f611c1ad7bae |
philipbrito
approved these changes
May 15, 2019
Contributor
philipbrito
left a comment
There was a problem hiding this comment.
I've fixed the requested changes here.
Thanks for sending this PR.
hfeky
reviewed
May 15, 2019
| <item name="android:fontFamily">sans-serif-medium</item> | ||
| <item name="android:textStyle">normal</item> | ||
| <item name="android:layout_marginTop">24dp</item> | ||
| <item name="android:layout_gravity">left</item> |
Contributor
There was a problem hiding this comment.
layout_gravity should be start instead of left to support RTL languages.
Contributor
There was a problem hiding this comment.
Thanks for the catch @HusseinElFeky!
Changed!
280f1c1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/android
Closes #2079
Changes: Create new style for EditTex and TextView on Profile Fragment. Adds username, email and name hint according to a web interface.
Screenshots or GIF for the change: