[NEW] Redesign chat list.

app/src/main/java/chat/rocket/android/chatrooms/adapter/RoomUiModelMapper.kt

@@ -2,9 +2,6 @@ package chat.rocket.android.chatrooms.adapter
 
 import android.app.Application
 import android.text.SpannableStringBuilder
-import androidx.core.content.ContextCompat
-import androidx.core.text.bold
-import androidx.core.text.color
 import chat.rocket.android.R
 import chat.rocket.android.chatrooms.adapter.model.RoomUiModel
 import chat.rocket.android.db.model.ChatRoom
@@ -32,18 +29,13 @@ class RoomUiModelMapper(
     private val serverUrl: String,
     private val permissions: PermissionsInteractor
 ) {
-    private val nameUnreadColor = ContextCompat.getColor(context, R.color.colorPrimaryText)
-    private val nameColor = ContextCompat.getColor(context, R.color.colorSecondaryText)
-    private val dateUnreadColor = ContextCompat.getColor(context, R.color.colorAccent)
-    private val dateColor = ContextCompat.getColor(context, R.color.colorSecondaryText)
-    private val messageUnreadColor = ContextCompat.getColor(context, android.R.color.primary_text_light)
-    private val messageColor = ContextCompat.getColor(context, R.color.colorSecondaryText)
-
-    private val currentUser by lazy {
-        userInteractor.get()
-    }
+    private val currentUser by lazy { userInteractor.get() }
 
-    fun map(rooms: List<ChatRoom>, grouped: Boolean = false, showLastMessage: Boolean = true): List<ItemHolder<*>> {
+    fun map(
+        rooms: List<ChatRoom>,
+        grouped: Boolean = false,
+        showLastMessage: Boolean = true
+    ): List<ItemHolder<*>> {
         val list = ArrayList<ItemHolder<*>>(rooms.size + 4)
         var lastType: String? = null
         rooms.forEach { room ->
@@ -72,7 +64,7 @@ class RoomUiModelMapper(
 
     private fun mapUser(user: User): RoomUiModel {
         return with(user) {
-            val name = mapName(user.username!!, user.name, false)
+            val name = mapName(user.username!!, user.name)
             val status = user.status
             val avatar = serverUrl.avatarUrl(user.username!!)
             val username = user.username!!
@@ -88,41 +80,56 @@ class RoomUiModelMapper(
         }
     }
 
-    private fun mapRoom(room: Room, showLastMessage:Boolean = true): RoomUiModel {
+    private fun mapRoom(room: Room, showLastMessage: Boolean = true): RoomUiModel {
         return with(room) {
             RoomUiModel(
                 id = id,
                 name = name!!,
                 type = type,
                 avatar = serverUrl.avatarUrl(name!!, isGroupOrChannel = true),
-                lastMessage = if(showLastMessage) { mapLastMessage(lastMessage?.sender?.id, lastMessage?.sender?.username,
+                lastMessage = if (showLastMessage) {
+                    mapLastMessage(
+                        lastMessage?.sender?.id, lastMessage?.sender?.username,
                         lastMessage?.sender?.name, lastMessage?.message,
-                        isDirectMessage = type is RoomType.DirectMessage)} else { null },
+                        isDirectMessage = type is RoomType.DirectMessage
+                    )
+                } else {
+                    null
+                },
                 muted = muted.orEmpty(),
                 writable = isChannelWritable(muted)
             )
         }
     }
 
-    fun map(chatRoom: ChatRoom, showLastMessage:Boolean = true): RoomUiModel {
+    fun map(chatRoom: ChatRoom, showLastMessage: Boolean = true): RoomUiModel {
         return with(chatRoom.chatRoom) {
             val isUnread = alert || unread > 0
             val type = roomTypeOf(type)
             val status = chatRoom.status?.let { userStatusOf(it) }
-            val roomName = mapName(name, fullname, isUnread)
-            val timestamp = mapDate(lastMessageTimestamp ?: updatedAt, isUnread)
+            val roomName = mapName(name, fullname)
+            val timestamp = mapDate(lastMessageTimestamp ?: updatedAt)
             val avatar = if (type is RoomType.DirectMessage) {
                 serverUrl.avatarUrl(name)
             } else {
                 serverUrl.avatarUrl(name, isGroupOrChannel = true)
             }
             val unread = mapUnread(unread)
-            val lastMessage = if(showLastMessage) { mapLastMessage(lastMessageUserId, chatRoom.lastMessageUserName,
-                    chatRoom.lastMessageUserFullName, lastMessageText, isUnread,
-                    type is RoomType.DirectMessage) } else { null }
+            val lastMessage = if (showLastMessage) {
+                mapLastMessage(
+                    lastMessageUserId,
+                    chatRoom.lastMessageUserName,
+                    chatRoom.lastMessageUserFullName,
+                    lastMessageText,
+                    type is RoomType.DirectMessage
+                )
+            } else {
+                null
+            }
             val open = open
 
-            val lastMessageMarkdown = lastMessage?.let { Markwon.markdown(context, it.toString()).toString() }
+            val lastMessageMarkdown =
+                lastMessage?.let { Markwon.markdown(context, it.toString()).toString() }
 
             RoomUiModel(
                 id = id,
@@ -158,60 +165,43 @@ class RoomUiModelMapper(
         }
     }
 
-    private fun mapLastMessage(userId: String?, name: String?, fullName: String?, text: String?,
-                               unread: Boolean = false,
-                               isDirectMessage: Boolean = false): CharSequence? {
-
+    private fun mapLastMessage(
+        userId: String?,
+        name: String?,
+        fullName: String?,
+        text: String?,
+        isDirectMessage: Boolean = false
+    ): CharSequence? {
         return if (!settings.showLastMessage()) {
             null
         } else if (name != null && text != null) {
             val user = if (currentUser != null && currentUser!!.id == userId) {
                 "${context.getString(R.string.msg_you)}: "
             } else {
-                if (isDirectMessage) "" else "${mapName(name, fullName, unread)}: "
+                if (isDirectMessage) "" else "${mapName(name, fullName)}: "
             }
-
-            val color = if (unread) messageUnreadColor else messageColor
-
-            SpannableStringBuilder()
-                    .color(color) {
-                        bold { append(user) }
-                        append(text)
-                    }
+            SpannableStringBuilder().append(user).append(text)
         } else {
             context.getText(R.string.msg_no_messages_yet)
         }
     }
 
-    private fun mapName(name: String, fullName: String?, unread: Boolean): CharSequence {
-        val roomName = if (settings.useSpecialCharsOnRoom() || settings.useRealName()) {
+    private fun mapName(name: String, fullName: String?): CharSequence {
+        return if (settings.useSpecialCharsOnRoom() || settings.useRealName()) {
             fullName ?: name
         } else {
             name
         }
-
-        val color = if (unread) nameUnreadColor else nameColor
-        return SpannableStringBuilder()
-                .color(color) {
-                    append(roomName)
-                }
     }
 
     private fun mapUnread(unread: Long): String? {
-        return when(unread) {
+        return when (unread) {
             0L -> null
             in 1..99 -> unread.toString()
             else -> context.getString(R.string.msg_more_than_ninety_nine_unread_messages)
 
         }
     }
 
-    private fun mapDate(date: Long?, unread: Boolean): CharSequence? {
-        return date?.localDateTime()?.date(context)?.let {
-            val color = if (unread) dateUnreadColor else dateColor
-            SpannableStringBuilder().color(color) {
-                append(it)
-            }
-        }
-    }
+    private fun mapDate(date: Long?): CharSequence? = date?.localDateTime()?.date(context)
 }

app/src/main/java/chat/rocket/android/chatrooms/adapter/RoomViewHolder.kt

@@ -4,80 +4,92 @@ import android.content.res.Resources
 import android.graphics.drawable.Drawable
 import android.view.View
 import androidx.core.view.isGone
+import androidx.core.view.isInvisible
 import androidx.core.view.isVisible
 import chat.rocket.android.R
 import chat.rocket.android.chatrooms.adapter.model.RoomUiModel
 import chat.rocket.common.model.RoomType
 import chat.rocket.common.model.UserStatus
 import kotlinx.android.synthetic.main.item_chat.view.*
 import kotlinx.android.synthetic.main.unread_messages_badge.view.*
-import ru.noties.markwon.Markwon
-
-class RoomViewHolder(itemView: View, private val listener: (RoomUiModel) -> Unit) : ViewHolder<RoomItemHolder>(itemView) {
 
+class RoomViewHolder(itemView: View, private val listener: (RoomUiModel) -> Unit) :
+    ViewHolder<RoomItemHolder>(itemView) {
     private val resources: Resources = itemView.resources
-    private val channelUnread: Drawable = resources.getDrawable(R.drawable.ic_hashtag_black_12dp)
-    private val channel: Drawable = resources.getDrawable(R.drawable.ic_hashtag_12dp)
-    private val groupUnread: Drawable = resources.getDrawable(R.drawable.ic_lock_black_12_dp)
-    private val group: Drawable = resources.getDrawable(R.drawable.ic_lock_12_dp)
-    private val online: Drawable = resources.getDrawable(R.drawable.ic_status_online_12dp)
-    private val away: Drawable = resources.getDrawable(R.drawable.ic_status_away_12dp)
-    private val busy: Drawable = resources.getDrawable(R.drawable.ic_status_busy_12dp)
-    private val offline: Drawable = resources.getDrawable(R.drawable.ic_status_invisible_12dp)
+    private val channelIcon: Drawable = resources.getDrawable(R.drawable.ic_hashtag_12dp)
+    private val groupIcon: Drawable = resources.getDrawable(R.drawable.ic_lock_12_dp)
+    private val onlineIcon: Drawable = resources.getDrawable(R.drawable.ic_status_online_12dp)
+    private val awayIcon: Drawable = resources.getDrawable(R.drawable.ic_status_away_12dp)
+    private val busyIcon: Drawable = resources.getDrawable(R.drawable.ic_status_busy_12dp)
+    private val offlineIcon: Drawable = resources.getDrawable(R.drawable.ic_status_invisible_12dp)
 
     override fun bindViews(data: RoomItemHolder) {
         val room = data.data
         with(itemView) {
             image_avatar.setImageURI(room.avatar)
             text_chat_name.text = room.name
 
+            if (room.status != null && room.type is RoomType.DirectMessage) {
+                image_chat_icon.setImageDrawable(getStatusDrawable(room.status))
+            } else {
+                image_chat_icon.setImageDrawable(getRoomDrawable(room.type))
+            }
+
             if (room.lastMessage != null) {
-                text_last_message.isVisible = true
                 text_last_message.text = room.lastMessage
+                text_last_message.isVisible = true
             } else {
                 text_last_message.isGone = true
             }
 
             if (room.date != null) {
-                text_last_message_date_time.isVisible = true
-                text_last_message_date_time.text = room.date
+                text_timestamp.text = room.date
+                text_timestamp.isVisible = true
             } else {
-                text_last_message_date_time.isGone = true
+                text_timestamp.isInvisible = true
             }
 
             if (room.unread != null) {
-                text_total_unread_messages.isVisible = true
                 text_total_unread_messages.text = room.unread
+                text_total_unread_messages.isVisible = true
             } else {
-                text_total_unread_messages.isGone = true
+                text_total_unread_messages.isInvisible = true
             }
 
-            if (room.status != null && room.type is RoomType.DirectMessage) {
-                image_chat_icon.setImageDrawable(getStatusDrawable(room.status))
-            } else {
-                image_chat_icon.setImageDrawable(getRoomDrawable(room.type, room.alert))
+            context?.let {
+                if (room.alert || room.unread != null) {
+                    text_timestamp.setTextAppearance(it, R.style.ChatList_Timestamp_Unread_TextView)
+                    text_last_message.setTextAppearance(
+                        it,
+                        R.style.ChatList_LastMessage_Unread_TextView
+                    )
+                    text_total_unread_messages.text = "!"
+                    text_total_unread_messages.isVisible = true
+                } else {
+                    text_timestamp.setTextAppearance(it, R.style.ChatList_Timestamp_TextView)
+                    text_last_message.setTextAppearance(it, R.style.ChatList_LastMessage_TextView)
+                    text_total_unread_messages.isInvisible = true
+                }
             }
 
-            setOnClickListener {
-                listener(room)
-            }
+            setOnClickListener { listener(room) }
         }
     }
 
-    private fun getRoomDrawable(type: RoomType, alert: Boolean): Drawable? {
-        return when(type) {
-            is RoomType.Channel -> if (alert) channelUnread else channel
-            is RoomType.PrivateGroup -> if (alert) groupUnread else group
+    private fun getRoomDrawable(type: RoomType): Drawable? {
+        return when (type) {
+            is RoomType.Channel -> channelIcon
+            is RoomType.PrivateGroup -> groupIcon
             else -> null
         }
     }
 
     private fun getStatusDrawable(status: UserStatus): Drawable {
-        return when(status) {
-            is UserStatus.Online -> online
-            is UserStatus.Away -> away
-            is UserStatus.Busy -> busy
-            else -> offline
+        return when (status) {
+            is UserStatus.Online -> onlineIcon
+            is UserStatus.Away -> awayIcon
+            is UserStatus.Busy -> busyIcon
+            else -> offlineIcon
         }
     }
 }

app/src/main/java/chat/rocket/android/chatrooms/adapter/RoomsAdapter.kt

@@ -6,7 +6,8 @@ import chat.rocket.android.R
 import chat.rocket.android.chatrooms.adapter.model.RoomUiModel
 import chat.rocket.android.util.extensions.inflate
 
-class RoomsAdapter(private val listener: (RoomUiModel) -> Unit) : RecyclerView.Adapter<ViewHolder<*>>() {
+class RoomsAdapter(private val listener: (RoomUiModel) -> Unit) :
+    RecyclerView.Adapter<ViewHolder<*>>() {
 
     init {
         setHasStableIds(true)
@@ -40,16 +41,16 @@ class RoomsAdapter(private val listener: (RoomUiModel) -> Unit) : RecyclerView.A
 
     override fun getItemId(position: Int): Long {
         val item = values[position]
-        return when(item) {
-            is HeaderItemHolder -> item.data.hashCode().toLong()
+        return when (item) {
             is RoomItemHolder -> item.data.id.hashCode().toLong()
+            is HeaderItemHolder -> item.data.hashCode().toLong()
             is LoadingItemHolder -> "loading".hashCode().toLong()
             else -> throw IllegalStateException("View type must be either Room, Header or Loading")
         }
     }
 
     override fun getItemViewType(position: Int): Int {
-        return when(values[position]) {
+        return when (values[position]) {
             is RoomItemHolder -> VIEW_TYPE_ROOM
             is HeaderItemHolder -> VIEW_TYPE_HEADER
             is LoadingItemHolder -> VIEW_TYPE_LOADING