This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Redesign chat list. #1890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Rocket.Chat.Android into improvement/chat-list-layout
…nto improvement/chat-list-layout
rafaelks
approved these changes
Dec 7, 2018
rafaelks
suggested changes
Dec 7, 2018
Contributor
rafaelks
left a comment
There was a problem hiding this comment.
Found few bugs, reported internally.
…nto improvement/chat-list-layout
…Rocket.Chat.Android into improvement/chat-list-layout
luciofm
reviewed
Dec 7, 2018
| if (room.unread != null) { | ||
| if (room.alert) { | ||
| if (room.unread == null) text_total_unread_messages.text = "!" | ||
| if (room.unread != null) text_total_unread_messages.text = room.unread |
Contributor
There was a problem hiding this comment.
this is actually an else :)
also you can do text_total_unread_messages.text = room.unread ?: "!"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redesign the chat list view and also closes #864
Note: It's need to change the group icon.