2.x UnicastProcessor fail-fast support#5226
Conversation
| */ | ||
| @CheckReturnValue | ||
| @Experimental | ||
| public static <T> UnicastProcessor<T> create(int capacityHint, Runnable onCancelled, boolean delayError) { |
There was a problem hiding this comment.
nit: newline between onCancelled,delayError
| * Creates an UnicastProcessor with the given capacity hint. | ||
| * @param capacityHint the capacity hint for the internal, unbounded queue | ||
| * @since 2.0 | ||
| */ |
There was a problem hiding this comment.
Is this one really necessary?
There was a problem hiding this comment.
could you elaborate a bit?
Codecov Report
@@ Coverage Diff @@
## 2.x #5226 +/- ##
============================================
+ Coverage 96.01% 96.07% +0.06%
- Complexity 5747 5758 +11
============================================
Files 628 628
Lines 41085 41099 +14
Branches 5698 5703 +5
============================================
+ Hits 39446 39485 +39
+ Misses 657 642 -15
+ Partials 982 972 -10
Continue to review full report at Codecov.
|
akarnokd
left a comment
There was a problem hiding this comment.
One of the new package-private constructors is unnecessary.
| * @param capacityHint the capacity hint for the internal, unbounded queue | ||
| * @param delayError deliver pending onNext events before onError | ||
| * @since 2.0.8 - experimental | ||
| */ |
There was a problem hiding this comment.
3 args constructor has non-null onTerminate check; should i move this check to factory?
There was a problem hiding this comment.
Could you move that check into the appropriate create method(s)?
…tory methods, fixed typo
This PR adds support for fail-fast behavior to
UnicastProcessorwith methodsUnicastProcessor<T> create(boolean delayError),UnicastProcessor<T> create(int capacityHint, Runnable onTerminated, boolean delayError). Relates to #5165, #5217