[2.x] UnicastSubject fail fast support#5217
Merged
akarnokd merged 4 commits intoReactiveX:2.xfrom Mar 23, 2017
Merged
Conversation
vanniktech
reviewed
Mar 23, 2017
| * @return an UnicastSubject instance | ||
| */ | ||
| @CheckReturnValue | ||
| public static <T> UnicastSubject<T> create(int capacityHint, Runnable onTerminate, boolean delayError) { |
Collaborator
There was a problem hiding this comment.
Should this be marked Experimental?
| * @return an UnicastSubject instance | ||
| */ | ||
| @CheckReturnValue | ||
| public static <T> UnicastSubject<T> create(boolean delayError) { |
Collaborator
There was a problem hiding this comment.
Should this be marked Experimental?
| } | ||
|
|
||
| /** | ||
| * Creates an UnicastSubject with an internal buffer capacity hint 16 and given delay error flag |
| * @param capacityHint the capacity hint for the internal, unbounded queue | ||
| * @since 2.0 | ||
| */ | ||
| UnicastSubject(int capacityHint) { |
Collaborator
There was a problem hiding this comment.
Is this one really needed? The factories could just go and call UnicastSubject(capacityHint, true) ?
Codecov Report
@@ Coverage Diff @@
## 2.x #5217 +/- ##
============================================
- Coverage 96.04% 95.99% -0.05%
- Complexity 5705 5711 +6
============================================
Files 624 624
Lines 40683 40705 +22
Branches 5648 5655 +7
============================================
+ Hits 39075 39076 +1
- Misses 632 655 +23
+ Partials 976 974 -2
Continue to review full report at Codecov.
|
…nstructor, fix typos
akarnokd
reviewed
Mar 23, 2017
Member
akarnokd
left a comment
There was a problem hiding this comment.
Could you also do it for UnicastProcessor?
| @@ -127,12 +128,13 @@ public static <T> UnicastSubject<T> create(int capacityHint, Runnable onTerminat | |||
| * @return an UnicastSubject instance | |||
| */ | |||
Member
There was a problem hiding this comment.
Also please add @since 2.0.8 - experimental to all the new methods.
Contributor
Author
|
Yes, will do that as separate PR |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for fail-fast behavior to
UnicastSubjectwith methodsUnicastSubject<T> create(boolean delayError),UnicastSubject<T> create(int capacityHint, Runnable onTerminated, boolean delayError). Relates to #5165