Skip to content

2.x: Single.subscribe() to report isDisposed() true on success/error #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akarnokd merged 1 commit into from
Mar 8, 2017
Merged

2.x: Single.subscribe() to report isDisposed() true on success/error #5163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/io/reactivex/internal/observers/ConsumerSingleObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public ConsumerSingleObserver(Consumer<? super T> onSuccess, Consumer<? super Th

@Override
public void onError(Throwable e) {
lazySet(DisposableHelper.DISPOSED);
try {
onError.accept(e);
} catch (Throwable ex) {
Expand All @@ -55,6 +56,7 @@ public void onSubscribe(Disposable d) {

@Override
public void onSuccess(T value) {
lazySet(DisposableHelper.DISPOSED);
try {
onSuccess.accept(value);
} catch (Throwable ex) {
Expand Down
10 changes: 10 additions & 0 deletions src/test/java/io/reactivex/single/SingleSubscribeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,4 +217,14 @@ public void methodTestNoCancel() {

assertTrue(ps.hasObservers());
}

@Test
public void successIsDisposed() {
assertTrue(Single.just(1).subscribe().isDisposed());
}

@Test
public void errorIsDisposed() {
assertTrue(Single.error(new TestException()).subscribe(Functions.emptyConsumer(), Functions.emptyConsumer()).isDisposed());
}
}