2.x: Single.subscribe() to report isDisposed() true on success/error#5163
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Mar 8, 2017
Merged
2.x: Single.subscribe() to report isDisposed() true on success/error#5163akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5163 +/- ##
============================================
- Coverage 95.97% 95.95% -0.02%
+ Complexity 5655 5653 -2
============================================
Files 621 621
Lines 39960 39962 +2
Branches 5610 5610
============================================
- Hits 38351 38345 -6
- Misses 628 648 +20
+ Partials 981 969 -12
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Mar 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ConsumerSingleObserverdidn't reportisDisposedconsistently with its state.Reported in #5160.