1.x: Completable class to support valueless event composition + tests#3444
Merged
akarnokd merged 1 commit intoReactiveX:1.xfrom Dec 7, 2015
Merged
1.x: Completable class to support valueless event composition + tests#3444akarnokd merged 1 commit intoReactiveX:1.xfrom
akarnokd merged 1 commit intoReactiveX:1.xfrom
Conversation
54f5284 to
01f34a7
Compare
|
Looks good. Should we annotate |
Member
Author
|
Now, the class annotation should indicate all methods are experimental. If individual methods get promoted, we can add direct annotations then. |
|
Sounds good 👍 On Sat, Dec 5, 2015, 01:38 David Karnok notifications@github.com wrote:
|
Member
Author
|
Since this adds to the API surface, I'd like to get another like before merging. |
Member
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Dec 7, 2015
1.x: Completable class to support valueless event composition + tests
|
Awesome. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #3439.