2.x: Completable class for valueless event composition.#3439
2.x: Completable class for valueless event composition.#3439akarnokd wants to merge 1 commit intoReactiveX:2.xfrom
Conversation
|
I'm adding unit tests and some fixes, stay tuned. |
9fd5b65 to
1c1a6cf
Compare
|
Added 240 unit tests and fixed a few bugs. |
1c1a6cf to
e824aff
Compare
|
I've added |
There was a problem hiding this comment.
@akarnokd do you really see much sense in a separate class for arrays?
You can provide an override where passed array will be wrapped into ArrayList and then passed to the CompletableOnSubscribeConcatIterable.
Less code — less bugs :)
There was a problem hiding this comment.
Less allocation, more performant code.
|
What is the difference between Hope this helps. Just ignore me if you think that this is non sense. I see that @akarnokd are doing amazing things this days (specially rxjava v2), I'm not try to say that this pull request is bad or something similar. |
|
The difference is that, among other things, you don't have to drag around a mute type parameter. Null values are forbidden with 2.x and Reactive-Streams anyway. |
|
Consider making |
|
I've started out with |
|
Well that really sucks that |
|
You can't have wildcards as the type parameter of the super type. |
|
:( Oh well. |
|
Is there any chance we will get this with RxJava 1.x? |
|
The PR for 1.x has already been merged and should appear in 1.1.1 |
|
see #3444 |
|
Closing, will be included in the complete backport PR. |
I saw this mentioned in this talk from @benjchristensen
This PR adds a new class
Completablewhich allows composing eventsthat never want to fire
onNext, but onlyonErrororonComplete. Itis built upon the same Reactive-Streams principles as
Single,NbpObservableandObservable.I've added most methods that made sense and left out the others (such as
mapandflatMap) that would require at least a single value.Depending on whether this type is actually required, I'll add unit test to this PR or in a new PR in case this gets merged.