Add in DLPNO-CCSD(T)/def2-tzvp//wb97xd/def2tzvp model chemistry into the reference database#404
Draft
amarkpayne wants to merge 3 commits into
Draft
Add in DLPNO-CCSD(T)/def2-tzvp//wb97xd/def2tzvp model chemistry into the reference database#404amarkpayne wants to merge 3 commits into
amarkpayne wants to merge 3 commits into
Conversation
Member
Author
|
Additions made possible by the code add to RMG-Py here, but the two PRs can be merged independently |
cgrambow
reviewed
Apr 30, 2020
cgrambow
left a comment
There was a problem hiding this comment.
Some discussion needed. Also related to ReactionMechanismGenerator/RMG-Py#1935.
| 3 H u0 p0 c0 {1,S} | ||
| 4 H u0 p0 c0 {2,S} | ||
| calculated_data: | ||
| dlpno-ccsd(t)/def2-tzvp//wb97xd/def2tzvp: |
There was a problem hiding this comment.
I suggest we establish consistent naming conventions everywhere and use notation including hyphens, i.e., dlpno-ccsd(t)/def2-tzvp//wb97x-d/def2-tzvp. I also note this in ReactionMechanismGenerator/RMG-Py#1935.
| - N | ||
| - N | ||
| - H | ||
| wb97xd/def2tzvp: |
There was a problem hiding this comment.
Same comment here. wb97x-d/def2-tzvp.
|
Based on our discussion today, does this data include anions? |
d7898e5 to
290f754
Compare
This was referenced May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @dranasinghe for the calculations!!
This PR also fixes some issues with existing species in the reference species database