Skip to content

update transform 2d demo#162

Merged
wyli merged 2 commits into
Project-MONAI:masterfrom
wyli:161-fixes-transform-2d
Mar 29, 2021
Merged

update transform 2d demo#162
wyli merged 2 commits into
Project-MONAI:masterfrom
wyli:161-fixes-transform-2d

Conversation

@wyli

@wyli wyli commented Mar 26, 2021

Copy link
Copy Markdown
Contributor

fixes #161

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested a review from Nic-Ma March 26, 2021 07:25
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wyli wyli requested review from ericspod and rijobro March 26, 2021 07:25
@wyli wyli force-pushed the 161-fixes-transform-2d branch from d63028f to b649c72 Compare March 26, 2021 08:46
Comment thread modules/transforms_demo_2d.ipynb Outdated
Comment on lines 289 to 290
"new_img = affine(im_data, (300, 400), mode=\"bilinear\")\n",
"new_seg = affine(seg_data, (300, 400), mode=\"nearest\")\n",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the following, and then the rest can remain unchanged?

Suggested change
"new_img = affine(im_data, (300, 400), mode=\"bilinear\")\n",
"new_seg = affine(seg_data, (300, 400), mode=\"nearest\")\n",
"new_img, _ = affine(im_data, (300, 400), mode=\"bilinear\")\n",
"new_seg, _ = affine(seg_data, (300, 400), mode=\"nearest\")\n",

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested a review from rijobro March 27, 2021 10:37
@wyli wyli merged commit 4eee7fb into Project-MONAI:master Mar 29, 2021
@wyli wyli deleted the 161-fixes-transform-2d branch July 29, 2021 08:23
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* fixes Project-MONAI#161

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transform 2d demo test error

3 participants