2495 Enhance PatchEmbeddingBlock#2496
Merged
Merged
Conversation
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
Hi @wyli , There is only 1 change is really related to the code, I removed the Thanks. |
Contributor
|
Could you please help confirm the changes in this PR? @ahatamiz |
yiheng-wang-nv
approved these changes
Jul 1, 2021
ahatamiz
approved these changes
Jul 1, 2021
ahatamiz
left a comment
Contributor
There was a problem hiding this comment.
Thanks. Changes look nice.
Contributor
Just reviewed. Everything looks good. |
Contributor
Contributor
Author
|
Hi @wyli , I didn't check every line of UNETR related logic, so I marked as "partly". I will try to double confirm ASAP later. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partly fixes issue 2495 .
Description
This PR enhanced the
PatchEmbeddingBlockto fix CI tests and fixed wrong data type, removed unused args.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.