Minor code format issue in PatchEmbeddingBlock

[Nic-Ma]

Describe the bug
If running /black, the change in the newly added PatchEmbeddingBlock will cause CI error.
https://github.com/Project-MONAI/MONAI/blob/dev/monai/networks/blocks/patchembedding.py
And there are also some other potential issues about the input args.

[Nic-Ma]

I will add more code checks to PatchEmbeddingBlock and format it in a quick PR.
Thanks.

[wyli]

I think this autofix breaks the type ignore command be33e85

[Nic-Ma]

Hi @wyli ,

Yes, it is just 1 issue in PatchEmbeddingBlock, but the root cause is that we should not add type ignore at all, the typehint is not correct.

Thanks.

[wyli]

Sure, I hope this new feature release won't get stuck at the details of (unstable) type checking, given that the code showed good performance on some segmentation tasks. Would be great if the 'type ignore' could be removed, but it's not an urgent request for now, please make sure it's a nonbreaking fix...cc @ahatamiz

[Nic-Ma]

Hi @wyli and @ahatamiz ,

Yes, I agree with you, and I made a quick to address the issues: #2496.
Could you please help review it?
We can revisit more details later.

Thanks.

[ahatamiz]

Hi @Nic-Ma and @wyli

I think #2496 already addresses these issues. @Nic-Ma would you please confirm ?

Thanks.

[Nic-Ma]

Hi @ahatamiz ,

Let's close this ticket for now.
I will revisit all the related code to double confirm it, will reopen the ticket and submit PR if found any other issues.

Thanks for your review!

[ahatamiz]

Hi @Nic-Ma

Sure. Thank you for tracking down the issue on the PatchEmbeddingBlock. We can certainly revisit again.