Add support for adrenaline on stun mastery#7680
Closed
Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Closed
Add support for adrenaline on stun mastery#7680Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
Member
|
Performance loss deemed too great for too little gain. Also see comment on #7673 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Supersedes: #7673
Adds support for the "Gain Adrenaline when Stunned, for 2 seconds per 100ms of Stun Duration" stun mastery mod. Only applies if you have "Have you been stunned recently?" checked and your stun duration is higher than the value on the mod.
Implementation of the stun duration condition required making
calcs.buildDefenceEstimationsa dependency forcalc.offence. I've simply added the call to the end of calc.defense. This will likely have a negative impact on performance.Link to a build that showcases this PR:
NOTE: There seems to be a bug currently with the enemy level not updating when player level changes and only updating on config change. This
For output from #7162 see Paliak#7