Add support for adrenaline on stun mastery#7673
Closed
Nerotox wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Closed
Add support for adrenaline on stun mastery#7673Nerotox wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Nerotox wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Member
|
Since we have to tick a config anyway, it might as well be Adrenaline. Might revisit this one day if people start clamoring for this mastery in PoB. Btw, https://www.poewiki.net/wiki/Immutable_Force exists, so that's how most people would drop below 100ms of stun duration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds support for the "Gain Adrenaline when Stunned, for 2 seconds per 100ms of Stun Duration" stun mastery mod.
Only active if the "Have you been stunned recently" config is ticked.
Technically small improvement would be to check if the stun duration is longer than 100ms (mastery doesn't do anything ingame if it's lower than that), but I couldn't figure out how to set a condition in the calcsDefence that is then respected by the mod parser. Not really an issue tho, no real build has the 300%+ stun recovery needed where this case would apply.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/bVtxVL8hQwg9
Before screenshot:
After screenshot: