Skip to content

Adding popup to specify new user path if default one fails#7476

Merged
Wires77 merged 4 commits intoPathOfBuildingCommunity:devfrom
Wires77:unicode_crash
Mar 27, 2024
Merged

Adding popup to specify new user path if default one fails#7476
Wires77 merged 4 commits intoPathOfBuildingCommunity:devfrom
Wires77:unicode_crash

Conversation

@Wires77
Copy link
Member

@Wires77 Wires77 commented Mar 26, 2024

Fixes #7431 .

Description of the problem being solved:

This requires PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic#46 to function, and adds a workaround for users who have unicode characters in their default user path.

Still TODO:

  • Find a better way to check for a valid path
  • Implement loading settings and shared items after saving
  • Restore dev code loading settings from script path (currently always loading from user path for testing)
  • Add a link to a workaround document to prevent this from appearing every time

Screenshot and behaviour

image

To Test

Do the opposite of the workaround in this comment and set your Documents path to something with Cyrillic characters in it (e.g. Документи ): #7431 (comment)
You'll also have to comment out the if launch.devMode or (GetScriptPath() [...] conditional section on line 76 of src/Main.lua, otherwise the GetUserPath() function won't even get called.

@Wires77 Wires77 added the crash Causes PoB to crash and is High Priority label Mar 26, 2024
@Wires77 Wires77 marked this pull request as ready for review March 27, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crash Causes PoB to crash and is High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The application does not start after the update

2 participants