Adding popup to specify new user path if default one fails#7476
Merged
Wires77 merged 4 commits intoPathOfBuildingCommunity:devfrom Mar 27, 2024
Merged
Adding popup to specify new user path if default one fails#7476Wires77 merged 4 commits intoPathOfBuildingCommunity:devfrom
Wires77 merged 4 commits intoPathOfBuildingCommunity:devfrom
Conversation
zao
reviewed
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7431 .
Description of the problem being solved:
This requires PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic#46 to function, and adds a workaround for users who have unicode characters in their default user path.
Still TODO:
Screenshot and behaviour
To Test
Do the opposite of the workaround in this comment and set your Documents path to something with Cyrillic characters in it (e.g. Документи ): #7431 (comment)
You'll also have to comment out the
if launch.devMode or (GetScriptPath() [...]conditional section on line 76 ofsrc/Main.lua, otherwise theGetUserPath()function won't even get called.