Fix settings not saving for certain users#7505
Merged
Wires77 merged 2 commits intoPathOfBuildingCommunity:devfrom Mar 29, 2024
Merged
Fix settings not saving for certain users#7505Wires77 merged 2 commits intoPathOfBuildingCommunity:devfrom
Wires77 merged 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
81cf947 to
42e7ff4
Compare
Wires77
approved these changes
Mar 29, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason we were loading
Settings.xmland then immediately overwriting all of the values loaded with defaults. This fixes that by.. setting the defaults first, then loading.