fix initial settings done#967
Closed
pirelaurent wants to merge 1 commit into
Closed
Conversation
Member
|
I'm concerned that this pull request does not address any documented issues. It may not be merged. Since this software is open-source, you are free to modify as you please for your own needs, which is what I see in this code. |
Member
|
I recommend making an issue that states what the problem is. We have discussed completely refactoring software settings to make the code more simple. |
Author
|
Yes, settings is much more clear but the bug previously described by #942
is not corrected.
I reopen a #967 on same pb.
I hope you will read the analysis and solution.
My pull request was designed for that.
Apologize not to have reopen a bug before.
Please, have a look .
Le lun. 3 mai 2021 à 18:49, Richard Waltman ***@***.***> a
écrit :
… I recommend making an issue that states what the problem is. We have
discussed completely refactoring software settings to make the code more
simple.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#967 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABADNMI4ICMBJKRUQ7SPG3TTL3H2HANCNFSM4332DKUA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix a bug in settings .
See file pirla_README.MD
( first time i do a contribution, hope no mistake )