Several options ( Layout, Notch, Bandpass Filter, widgets,etc. ) in DefaultSettings.json are not applied by the app.

[pirelaurent]

Problem

DefaultSettings file is overwritten by app at every startup. Whatever you have saved as the default config, it is lost.
A main drawback motivation is for example Notch. If you leave in a country at 50hz, you must change by hand the notch each time even if you saved previously on defaultsettings (or you patch the file ) .

Expected

App must take care of the current defaultSettings.json values at startup.
I have proposed a pull request #967 with all explanations ( pirela_README.md) and solution (quite simple since settings refactoring :) )
Was closed probably because no relation with a bug. Now, there is one.
pirla_README.md

Operating System and Version

WIndows

GUI Version

5.0.4

Running standalone app

visual studio code or standalone

Type of OpenBCI Board

Cyton

Are you using a WiFi Shield?

No

Console Log

Paste any relevant text from the console window here

[retiutut]

App must take care of the current defaultSettings.json values at startup.
I have proposed a pull request #967 with all explanations ( pirela_README.md) and solution (quite simple since settings refactoring :) )
Was closed probably because no relation with a bug. Now, there is one.
pirla_README.md

I will review this carefully, and I have assigned this issue to myself. Thank you for bringing this up!

[pirelaurent]

Hello Richard, thanks to take this in account. As i'm new in the contribution process with fork and pull request, i'm not sure to have pull the right last one (may be forget a prior commit of my branch fixSettings) But, in any case, the pirla_README.md has all the (tiny) code to apply. I had leaved a question inside about galea and streaming code that are excluded of initial settings. But probably, we must load stored settings for them too. Ready to exchange if this help. have a nice day Pirla , from France Le mar. 4 mai 2021 à 18:36, Richard Waltman ***@***.***> a écrit :

…

App must take care of the current defaultSettings.json values at startup. I have proposed a pull request #967 <#967> with all explanations ( pirela_README.md) and solution (quite simple since settings refactoring :) ) Was closed probably because no relation with a bug. Now, there is one. pirla_README.md I will review this carefully, and I have assigned this issue to myself. Thank you for bringing this up! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#969 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABADNMK7Y6LA37H3HP4J4ILTMAPBFANCNFSM44BHI5KQ> .

[retiutut]

@pirelaurent I will see if this can be an easy fix, but I proposed a much broader and general fix to these kinds of issues, found here:

#970

https://github.com/OpenBCI/OpenBCI_GUI/milestone/10

[pirelaurent]

Hello, I saw #970 to generalize saving of widgets configuration, but my #969 is not on the same level, it's on the dynamic of settings, not on the content. (Just want that defaults settings previously saved are taken in account if it exists at startup before rewriting a fresh one. Same will stay if 970 was done) thanks Le mer. 5 mai 2021 à 23:29, Richard Waltman ***@***.***> a écrit :

…

@pirelaurent <https://github.com/pirelaurent> I will see if this can be an easy fix, but I proposed a much broader and general fix to these kinds of issues, found here: #970 <#970> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#969 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABADNMPQH24HP5EBDHSKX63TMG2FLANCNFSM44BHI5KQ> .

[retiutut]

DefaultSettings file is overwritten by app at every startup. Whatever you have saved as the default config, it is lost.
A main drawback motivation is for example Notch. If you leave in a country at 50hz, you must change by hand the notch each time even if you saved previously on defaultsettings (or you patch the file ) .

DefaultSettings.json is not meant to be used like this. It's meant to be the default configuration the GUI starts with. We overwrite this every time to account for newer versions of the GUI.

You will want to save and load from User settings files that are made with pressing n key or specified by pressing the "Save" button in the TopNav. Examples: SynthEightUserSettings.json or CytonUserSettings.json.

From the GUI console log:

[SUCCESS]: Settings Saved! The GUI will now load with these settings. Click "Default" to revert to factory settings.

[retiutut]

[SUCCESS]: Settings Saved! The GUI will now load with these settings. Click "Default" to revert to factory settings.

This message should be changed. The GUI will no longer auto-load saved user settings. This was a decision by the internal team some time ago.

@pirelaurent The quickest way to load your previous settings is to:

• Start Session
• Turn On Expert Mode
• Press lowercase n to save settings to CytonUserSettings.json, as an example. This name is autogenerated based on the data type. This is for users who may want different settings for different boards or data types.
• Start Session another time
• Turn On Expert Mode
• Press uppercase N