Skip to content

chore: sync development → nightly (2026-04-12) #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 3 commits into from
Apr 12, 2026
Merged

chore: sync development → nightly (2026-04-12) #92

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f1a61e
Merge pull request #89 from NodeByteHosting/development
CodeMeAPixel Apr 11, 2026
f0ef19b
Remove target='_blank' from resource links
CodeMeAPixel Apr 11, 2026
ed158d1
Merge pull request #91 from NodeByteHosting/production
CodeMeAPixel Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/ui/components/Static/navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,6 @@ export function Navigation() {
<DropdownMenuItem key={resource.title} asChild className="p-0 focus:bg-transparent">
<a
href={resource.href}
target="_blank"
rel="noopener noreferrer"
Copy link
Copy Markdown

@sentry sentry bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Removing target="_blank" from resource links causes external sites like the client area and game panel to open in the same tab, navigating users away from the main site.
Severity: MEDIUM

Suggested Fix

Conditionally render target="_blank" rel="noopener noreferrer" for links marked with external: true in the resources array. This will restore the expected behavior of opening external panels in a new tab while allowing internal links to navigate within the same tab.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/ui/components/Static/navigation.tsx#L421

Potential issue: The removal of `target="_blank"` from resource links in the
`Navigation` component means that links to external resources, such as the client
billing portal and game/VPS panels, will no longer open in a new tab. Instead, they will
navigate the user away from the main website within the same browser tab. This occurs
despite the data structure containing an `external: true` flag for these URLs, as this
flag is not used to conditionally render the `target` attribute. This change creates a
significant UX regression for critical user journeys, forcing users to manually navigate
back to the main site.

Did we get this right? 👍 / 👎 to inform future reviews.

className="flex items-start gap-3 rounded-lg p-3 hover:bg-accent/50 transition-colors group cursor-pointer w-full"
>
Expand Down Expand Up @@ -638,7 +637,6 @@ export function Navigation() {
<a
key={resource.title}
href={resource.href}
target="_blank"
rel="noopener noreferrer"
className="flex items-center gap-3 p-3 rounded-xl hover:bg-accent/50 transition-colors group"
onClick={() => setIsMobileMenuOpen(false)}
Expand Down