Skip to content

chore: sync development → nightly (2026-04-12)#92

Merged
github-actions[bot] merged 3 commits intonightlyfrom
development
Apr 12, 2026
Merged

chore: sync development → nightly (2026-04-12)#92
github-actions[bot] merged 3 commits intonightlyfrom
development

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Automated sync of development into nightly by workflow.

@github-actions github-actions bot merged commit 7e2d3a7 into nightly Apr 12, 2026
2 checks passed
@github-actions github-actions bot requested a review from CodeMeAPixel as a code owner April 12, 2026 01:23
<a
href={resource.href}
target="_blank"
rel="noopener noreferrer"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Removing target="_blank" from resource links causes external sites like the client area and game panel to open in the same tab, navigating users away from the main site.
Severity: MEDIUM

Suggested Fix

Conditionally render target="_blank" rel="noopener noreferrer" for links marked with external: true in the resources array. This will restore the expected behavior of opening external panels in a new tab while allowing internal links to navigate within the same tab.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/ui/components/Static/navigation.tsx#L421

Potential issue: The removal of `target="_blank"` from resource links in the
`Navigation` component means that links to external resources, such as the client
billing portal and game/VPS panels, will no longer open in a new tab. Instead, they will
navigate the user away from the main website within the same browser tab. This occurs
despite the data structure containing an `external: true` flag for these URLs, as this
flag is not used to conditionally render the `target` attribute. This change creates a
significant UX regression for critical user journeys, forcing users to manually navigate
back to the main site.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant