chore: sync development → nightly (2026-04-12)#92
Merged
github-actions[bot] merged 3 commits intonightlyfrom Apr 12, 2026
Merged
chore: sync development → nightly (2026-04-12)#92github-actions[bot] merged 3 commits intonightlyfrom
github-actions[bot] merged 3 commits intonightlyfrom
Conversation
feat: remove api related stuff for now
Remove blank target from internal links.
| <a | ||
| href={resource.href} | ||
| target="_blank" | ||
| rel="noopener noreferrer" |
There was a problem hiding this comment.
Bug: Removing target="_blank" from resource links causes external sites like the client area and game panel to open in the same tab, navigating users away from the main site.
Severity: MEDIUM
Suggested Fix
Conditionally render target="_blank" rel="noopener noreferrer" for links marked with external: true in the resources array. This will restore the expected behavior of opening external panels in a new tab while allowing internal links to navigate within the same tab.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/ui/components/Static/navigation.tsx#L421
Potential issue: The removal of `target="_blank"` from resource links in the
`Navigation` component means that links to external resources, such as the client
billing portal and game/VPS panels, will no longer open in a new tab. Instead, they will
navigate the user away from the main website within the same browser tab. This occurs
despite the data structure containing an `external: true` flag for these URLs, as this
flag is not used to conditionally render the `target` attribute. This change creates a
significant UX regression for critical user journeys, forcing users to manually navigate
back to the main site.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of development into nightly by workflow.