Skip to content

release: cherry-pick #905 to release#909

Closed
petekanev wants to merge 2 commits into
releasefrom
fix-905
Closed

release: cherry-pick #905 to release#909
petekanev wants to merge 2 commits into
releasefrom
fix-905

Conversation

@petekanev
Copy link
Copy Markdown
Contributor

Information about the fix can be found at #905

Also bump up package version to 3.4.1 in preparation for a hotfix release.

briandilley and others added 2 commits January 2, 2018 11:23
This fixes a number of currently broken nativescript plugins on android.  Basically any nativescript plugin that shipped with it's own jar file for native code is broken until this is made live.  In the interim i execute this command before building/running android (but after it is prepared and there is a `platforms/android` directory):

```
sed -Ei '' 's/"\$\{dep.directory\}\/platforms\/android"/"\$rootDir\/\${dep.directory}\/platforms\/android"/' platforms/android/app/build.gradle
```
@ns-bot
Copy link
Copy Markdown

ns-bot commented Jan 2, 2018

💔

@petekanev
Copy link
Copy Markdown
Contributor Author

CI Build error:

11:35:29 FAILURE: Build failed with an exception.
11:35:29 
11:35:29 * What went wrong:
11:35:29 Task 'runtests' not found in root project 'tns-android-PR'.

@petekanev petekanev closed this Jan 2, 2018
@petekanev petekanev deleted the fix-905 branch January 2, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants