fix(user template): problem with jar files in nativescript plugins#905
Merged
Conversation
This fixes a number of currently broken nativescript plugins on android. Basically any nativescript plugin that shipped with it's own jar file for native code is broken until this is made live. In the interim i execute this command before building/running android (but after it is prepared and there is a `platforms/android` directory):
```
sed -Ei '' 's/"\$\{dep.directory\}\/platforms\/android"/"\$rootDir\/\${dep.directory}\/platforms\/android"/' platforms/android/app/build.gradle
```
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
+1 |
Plamen5kov
approved these changes
Dec 28, 2017
Contributor
|
Great work @briandilley |
petekanev
pushed a commit
that referenced
this pull request
Jan 2, 2018
This fixes a number of currently broken nativescript plugins on android. Basically any nativescript plugin that shipped with it's own jar file for native code is broken until this is made live. In the interim i execute this command before building/running android (but after it is prepared and there is a `platforms/android` directory):
```
sed -Ei '' 's/"\$\{dep.directory\}\/platforms\/android"/"\$rootDir\/\${dep.directory}\/platforms\/android"/' platforms/android/app/build.gradle
```
petekanev
pushed a commit
that referenced
this pull request
Jan 2, 2018
This fixes a number of currently broken nativescript plugins on android. Basically any nativescript plugin that shipped with it's own jar file for native code is broken until this is made live. In the interim i execute this command before building/running android (but after it is prepared and there is a `platforms/android` directory):
```
sed -Ei '' 's/"\$\{dep.directory\}\/platforms\/android"/"\$rootDir\/\${dep.directory}\/platforms\/android"/' platforms/android/app/build.gradle
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a number of currently broken nativescript plugins on android. Basically any nativescript plugin that shipped with it's own jar file for native code is broken until this is made live. In the interim i execute this command before building/running android (but after it is prepared and there is a
platforms/androiddirectory):