Override cfdm.Field.get_domain to store axes cyclicity#769
Merged
sadielbartholomew merged 7 commits intoNCAS-CMS:mainfrom Apr 26, 2024
Merged
Override cfdm.Field.get_domain to store axes cyclicity#769sadielbartholomew merged 7 commits intoNCAS-CMS:mainfrom
cfdm.Field.get_domain to store axes cyclicity#769sadielbartholomew merged 7 commits intoNCAS-CMS:mainfrom
Conversation
| new_bounds[ | ||
| length - lower_offset : length, 1: | ||
| ] = old_bounds[length - 1, 1:] | ||
| new_bounds[length - lower_offset : length, 1:] = ( |
Member
Author
There was a problem hiding this comment.
This was just from linting the files I touched in this PR. For the release we can re-lint the whole codebase since it seems we are a bit behind on linting (black edits >10 files under cf/).
Member
Author
|
Merging after offline acceptance from @davidhassell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #762. The reason for the underlying issue was that the
Field.domainattribute calledget_domainwhich was inherited fromcfdm, which doesn't have the concept of cyclic axes. So quite similar in terms of cause to #763 (maybe we should check there aren't further cases of cyclic axes not being accounted for, in case other bugs might exist?).