Override del_construct to update cyclic axes set when due#763
Merged
sadielbartholomew merged 12 commits intoNCAS-CMS:mainfrom Apr 23, 2024
Merged
Conversation
Member
Author
|
Just going to add one commit to fix a few style/formatting issues detected by the CI linting. |
Member
Author
sadielbartholomew
left a comment
There was a problem hiding this comment.
@davidhassell one note to consider for your review. Thanks.
davidhassell
requested changes
Apr 22, 2024
Collaborator
davidhassell
left a comment
There was a problem hiding this comment.
Hi Sadie - look good - I've made some suggestions on handling the construct-doesn't exist case.
Member
Author
|
Thanks for your feedback @davidhassell. I'll update the PR shortly according to your excellent suggestions, though I will get the halo PR review in first, so do it after that. |
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Member
Author
|
All ready for your re-review, @davidhassell. Thanks. |
davidhassell
approved these changes
Apr 23, 2024
Collaborator
davidhassell
left a comment
There was a problem hiding this comment.
Look great. Thanks!
Member
Author
|
Thanks David. In that case, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #758 and #756 (the former being the underlying issue and the latter a specific bug as a downstream effect) by overriding the
del_constructinherited from cfdm to account for and update the store ofcyclicaxes. Previously we used the inherited method as-is so cyclic axes weren't updated and could get out of sync, notably contain axes which no longer existed due to deletion.Note:
test_Domain_del_constructadded here will currently fail halfway-through due tocyclic: different sets forField.domain& correspondingField#762, as noted in the test. I am fixing that next.