Conversation
GuillaumeRx
approved these changes
Jul 23, 2024
rekmarks
added a commit
to MetaMask/ocap-kernel
that referenced
this pull request
Jun 4, 2025
Ref: #461 The MetaMask extension is built for production using Browserify. Due to its age, Browserify ignores the `exports` field of `package.json`. Instead, when it encounters an import like `@metamask/streams/browser`, it will search the root directory of that package in `node_modules` for a file like `browser.js`. This PR adds such "mirror files" to all of our `@metamask/*` packages with export paths. For prior art, see: MetaMask/providers#351 In addition, we consolidate Vite's "assets" into the root output directory in `kernel-browser-runtime`. This turned out not be a necessary change, but I like it nevertheless. (The single file in that directory isn't an "asset", it's just a `.js` file.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new export for
StreamProviderto the root of the package, i.e.,@metamask/provider/stream-provider. Since #336 the stream provider is at./dist/StreamProvider.cjs(and.mjs), but Browserify isn't able to resolve this. For compatibility with Browserify, I've added astream-provider.jsto the root, which will be used by Browserify and other tools that don't support package exports.I haven't removed the previous
./dist/StreamProviderexport for backwards compatibility, but we should consider it deprecated and remove it in the next major release.