Conversation
Also move KernelStatus type to @MetaMask/ocap-kernel.
0a63e3b to
e306520
Compare
c71a6af to
eabf414
Compare
rekmarks
added a commit
that referenced
this pull request
Jun 3, 2025
#522 introduced the `kernel-browser-runtime` package, which bundled the kernel Web Worker. Further experiments indicated that it would be salutary for this package to bundle the vat worker, i.e. vat iframe, as well. To facilitate this, we replace `esbuild` with `vite` in `kernel-browser-runtime`, and extract all vat iframe-related functionality to this package. We also extract the extension's Vite plugins into a dedicated, private package so that they can be reused. Finally, during development, it was discovered that Vite duplicates the `@sqlite.org/sqlite.wasm` WASM binaries. This was a preexisting issue in the extension, when we bundled the kernel worker there. Thankfully, the duplicate files are extraneous and can be deleted, which is done using an inline plugin in `kernel-browser-runtime`. Many red herrings died in the creation of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses: #461
In preparation for integrating the kernel into https://github.com/MetaMask/metamask-extension, extracts the
kernel-integrationdirectory into a new package@metamask/kernel-browser-runtime. Makes some supporting refactors to this end.