Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

5.1.0#160

Merged
legobeat merged 2 commits intomainfrom
release/5.1.0
Sep 22, 2023
Merged

5.1.0#160
legobeat merged 2 commits intomainfrom
release/5.1.0

Conversation

@github-actions
Copy link
Contributor

This is the release candidate for version 5.1.0.

@legobeat
Copy link
Contributor

legobeat commented Sep 15, 2023

Reattempt of #151 (#158)

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/ethereumjs-tx 1.0.1 None +1 17.8 kB types
@types/randombytes 2.0.0 None +0 2.8 kB types
ethereumjs-tx 1.3.7 filesystem +38 6.52 MB holgerd77
@metamask/eslint-config-typescript 11.1.0 None +0 16.9 kB metamaskbot
@metamask/utils 5.0.2 None +3 438 kB metamaskbot

🚮 Removed packages: @metamask/eth-simple-keyring@5.0.0

@socket-security
Copy link

socket-security bot commented Sep 15, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: setimmediate@1.0.5, bs58@4.0.1, ripemd160@2.0.2, md5.js@1.3.5, rlp@2.2.7, ethereumjs-tx@1.3.7, brorand@1.1.0, buffer-xor@1.0.3, is-hex-prefixed@1.0.0, create-hash@1.2.0, ethereumjs-util@5.2.1, @types/randombytes@2.0.0, @types/ethereumjs-tx@1.0.1, ethjs-util@0.1.6, strip-hex-prefix@1.0.0, create-hmac@1.1.7, blakejs@1.2.1, minimalistic-assert@1.0.1, @types/ms@0.7.31, bn.js@4.12.0, bn.js@5.2.1, browserify-aes@1.2.0, evp_bytestokey@1.0.3, hash-base@3.1.0, scrypt-js@3.0.1, hash.js@1.1.7, elliptic@6.5.4, minimalistic-crypto-utils@1.0.1, cipher-base@1.0.4, ethereum-common@0.0.18, pbkdf2@3.1.2, hmac-drbg@1.0.1, @types/secp256k1@4.0.3, base-x@3.0.9, @types/pbkdf2@3.1.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat marked this pull request as ready for review September 15, 2023 21:58
@legobeat legobeat requested a review from a team as a code owner September 15, 2023 21:58
@legobeat legobeat requested review from a team, danroc and gantunesr September 15, 2023 21:58
@legobeat
Copy link
Contributor

@SocketSecurity ignore-all

@Gudahtt
Copy link
Member

Gudahtt commented Sep 18, 2023

Looks like the doc publishing step is failing because doc building scripts were added in #140 but typedoc wasn't added

@legobeat
Copy link
Contributor

legobeat commented Sep 18, 2023

Looks like the doc publishing step is failing because doc building scripts were added in #140 but typedoc wasn't added

Ah, I guess shouldn't have been dismissed in #151 (comment)

If the typedoc job should indeed be active:

@legobeat legobeat requested a review from a team September 21, 2023 09:15
@legobeat legobeat merged commit 5c12e42 into main Sep 22, 2023
@legobeat legobeat deleted the release/5.1.0 branch September 22, 2023 09:38
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Oct 20, 2023
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Oct 23, 2023
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Oct 2, 2024
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants