Typescript migration + standardization

[HowardBraham]

• Now using MetaMask/metamask-module-template
• Bump version of Node and npm packages
• Add GitHub workflows
• Add VSCode settings

[mikesposito]

Nice work! I didn't go through everything yet, but I left some small comments

[mikesposito]

I took a more detailed look into it, I left some suggestions around :)

[mcmire]

Good job on migrating this library. There were some TypeScript-related things I noticed but nothing major. A couple of things I wanted to highlight:

• It's important not to bump the version just yet to avoid a premature release (I've marked this as "requested changes" for this case in particular just so you notice)
• It seems that this PR does more than just migrate to TypeScript — it also brings in all of the GitHub workflows, VSCode settings, bumps the Node version, etc. — basically a bunch of standardization stuff — so it would probably be good to retitle the PR and/or update the PR description to encompass these changes so no one is caught off guard.

[socket-security]

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Ignoring: keccak@3.0.3, secp256k1@4.0.3

Pull request alert summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package	Capability Access	+/- Transitive Count	Publisher
@types/ethereumjs-tx@1.0.1	None	+1	types
@metamask/utils@5.0.0	None	+3	metamaskbot
ethereumjs-tx@1.3.7	None	+28	holgerd77
@types/randombytes@2.0.0	None	+0	types
typescript@4.8.4	filesystem	+0	typescript-bot
@metamask/eslint-config-typescript@11.1.0	None	+5	metamaskbot
depcheck@1.4.3	filesystem	+30	rumpl
ts-node@10.9.1	filesystem, shell, environment	+16	cspotcode
ts-jest@29.0.5	filesystem, environment	+79	kul
@typescript-eslint/parser@5.57.0	None	+1	jameshenry
@typescript-eslint/eslint-plugin@5.57.0	None	+4	jameshenry

⬆️ Updated Package	Version Diff	Capability Access	+/- Transitive Count	Publisher
jest@29.5.0	27.5.1...29.5.0	None	+75/-104	simenb
@types/jest@29.5.0	26.0.24...29.5.0	None	+13/-8	types

🚮 Removed packages: @metamask/eslint-config@8.0.0, eslint@7.32.0, eslint-plugin-prettier@3.4.1, prettier-plugin-packagejson@2.4.3

[mcmire]

Looks like there are a few more outstanding comments here (check hidden conversations) but this is looking good so far.

Dismissing since the version change has been reverted.

[mcmire]

Thanks for patiently working through my feedback. Nice work!

[mcmire]

@SocketSecurity ignore-all