ssh works again, removed no longer used files#440
Merged
Hirogen merged 1 commit intoDevelopmentfrom Jul 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR updates the SFTP plugin to use SSH.NET, removes legacy SharpSSH code, modernizes C# syntax across the codebase, and bumps the assembly version.
- Updated AssemblyInfo version and enabled
CopyLocalLockFileAssembliesin project files - Deleted unused SharpSSH-based SFTP implementation and cleanup of
<Compile Remove=…>entries - Refactored SftpLogFileInfo and related code with
var, range operators, and collection expressions - Modernized test code by trimming unused
usingdirectives
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Solution Items/AssemblyInfo.cs | Bumped assembly version to 1.20.0 |
| src/SftpFileSystemx86/SftpFileSystemx86.csproj | Added CopyLocalLockFileAssemblies, re-ordered package/project refs |
| src/SftpFileSystemx64/… | Removed legacy SharpSSH files, refactored NetSSH implementation |
| src/SftpFileSystemx64/SftpFileSystemx64.csproj | Added CopyLocalLockFileAssemblies; removed <Compile Remove> block |
| src/LogExpert.UI/Controls/LogWindow/LogWindow.cs | Modernized conditionals and added unmatched #endif |
| src/LogExpert.Core/Interface/IConfigManager.cs | Extended interface with new properties and methods without using |
| src/LogExpert.Tests/Various… | Stripped using System.IO/collections but introduced references in tests |
Comments suppressed due to low confidence (5)
src/LogExpert.UI/Controls/LogWindow/LogWindow.cs:561
- There is no matching
#ifdirective for this#endif, which will cause compile errors. Please remove or balance this directive.
#endif
src/LogExpert.Core/Interface/IConfigManager.cs:19
- The interface references
FileInfoandEventHandlerbut there are nousing System.IO;orusing System;directives. Add the necessaryusingstatements to ensure it compiles.
void Export (FileInfo fileInfo, SettingsFlags highlightSettings);
src/LogExpert.Tests/SquareBracketColumnizerTest.cs:19
- Removed
using System.IO;butPathis inSystem.IO. Please re-addusing System.IO;at the top soPath.Combineresolves.
var path = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, fileName);
src/LogExpert.Tests/RolloverHandlerTestBase.cs:60
- The test uses
File.MoveandDirectoryInfobutusing System.IO;was removed. Re-introduceusing System.IO;andusing System.Collections.Generic;forLinkedList<T>.
while (nextEnumerator.MoveNext())
src/LogExpert.Tests/BufferShiftTest.cs:37
- Removed
using System.Collections.Generic;, causingLinkedList<T>to be unresolved. Please re-add theusingdirective.
LinkedList<string> files = CreateTestFilesWithoutDate();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssh works again, removed no longer used files