418 gui design highlighting unreadable color#424
Merged
Hirogen merged 31 commits intoDevelopmentfrom Jun 26, 2025
Merged
Conversation
RandallFlagg
suggested changes
Jun 16, 2025
RandallFlagg
suggested changes
Jun 17, 2025
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindowEventHandlers.cs
Outdated
Show resolved
Hide resolved
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindowEventHandlers.cs
Outdated
Show resolved
Hide resolved
…ble-color # Conflicts: # src/LogExpert.Core/EventHandlers/EventHandlers.cs # src/LogExpert.UI/Entities/PaintHelper.cs
RandallFlagg
suggested changes
Jun 18, 2025
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindowEventHandlers.cs
Outdated
Show resolved
Hide resolved
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindowEventHandlers.cs
Outdated
Show resolved
Hide resolved
dotnet-version changed to 9.0.x
RandallFlagg
suggested changes
Jun 20, 2025
src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindowEventHandlers.cs
Outdated
Show resolved
Hide resolved
… are no longer resx problems when opening a form and visual studio creates a resx file
…ble-color # Conflicts: # src/LogExpert.UI/LogExpert.UI.csproj
…ble-color # Conflicts: # src/LogExpert.UI/Controls/LogWindow/LogWindowPrivate.cs
…ble-color # Conflicts: # src/LogExpert.UI/Controls/LogWindow/LogWindow.designer.cs
RandallFlagg
suggested changes
Jun 22, 2025
This was referenced Jun 23, 2025
Merged
RandallFlagg
suggested changes
Jun 24, 2025
|
|
||
| if (_logFileReader != null) | ||
| { | ||
| if (CurrentColumnizer is IPreProcessColumnizer columnizer1) |
Contributor
There was a problem hiding this comment.
Solve IDE0045:
_logFileReader.PreProcessColumnizer = CurrentColumnizer is IPreProcessColumnizer columnizer1 ? columnizer1 : null;
| { | ||
| //keeping this comment, because it's the original code | ||
| // = new Rectangle(e.CellBounds.Left + 2, e.CellBounds.Top + 2, 6, 6); | ||
| var r = e.CellBounds; |
Contributor
There was a problem hiding this comment.
Instead of the r do:
e.CellBounds.Inflate(-2, -2);
I think if you do that you can also remove the comment unless you really still want to keep it.
| Rectangle wordRect = new(wordPos, wordSize); | ||
|
|
||
| var foreColor = matchEntry.HighlightEntry.ForegroundColor; | ||
| if (!e.State.HasFlag(DataGridViewElementStates.Selected)) |
Contributor
There was a problem hiding this comment.
I prefer positive comparison over negative ones so if you don't mind change the condition.
| [SupportedOSPlatform("windows")] | ||
| private void CreateDefaultViewStyle () | ||
| { | ||
|
|
|
|
||
| e.Graphics.DrawString(entry.SearchText, e.Font, new SolidBrush(entry.ForegroundColor), | ||
| new PointF(rectangle.Left, rectangle.Top)); | ||
| e.Graphics.DrawString(entry.SearchText, e.Font, new SolidBrush(forgroundColor), new PointF(rectangle.Left, rectangle.Top)); |
Contributor
There was a problem hiding this comment.
Solid brush should be disposed:
using (var brush = new SolidBrush(forgroundColor))
{
e.Graphics.DrawString(entry.SearchText, e.Font, brush, new PointF(rectangle.Left, rectangle.Top));
}| IList<HighlightMatchEntry> matchList = logPaintCtx.FindHighlightMatches(value as ILogLine); | ||
| var matchList = logPaintCtx.FindHighlightMatches(value as ILogLine); | ||
| // too many entries per line seem to cause problems with the GDI | ||
| while (matchList.Count > 50) |
Contributor
There was a problem hiding this comment.
What is this number 50? I don't like magic numbers in the code so if it possible maybe remove it or put it in a const with a meaningful name or something else.
Regardless of the above, Simplify:
if (matchList.Count > 50)
{
matchList.RemoveRange(50, matchList.Count - 50);
}
| @@ -314,7 +368,7 @@ private static void PaintHighlightedCell (ILogPaintContextUI logPaintCtx, DataGr | |||
| { | |||
Contributor
There was a problem hiding this comment.
remove the gridView param
| @@ -314,7 +368,7 @@ private static void PaintHighlightedCell (ILogPaintContextUI logPaintCtx, DataGr | |||
| { | |||
| var value = e.Value ?? string.Empty; | |||
Contributor
There was a problem hiding this comment.
I think it is safe and more logic to change the code to:
var value = e.Value as ITextValue;
var matchList = logPaintCtx.FindHighlightMatches(value);maybe even to:
var value = e.Value as Column;| @@ -366,7 +420,7 @@ private static void PaintHighlightedCell (ILogPaintContextUI logPaintCtx, DataGr | |||
| } | |||
|
|
|||
|
|
|||
| @@ -314,7 +368,7 @@ private static void PaintHighlightedCell (ILogPaintContextUI logPaintCtx, DataGr | |||
| { | |||
Contributor
There was a problem hiding this comment.
I would put a TODO: Refactor on this method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.