Update documentation and clean up implementation of indexing functions #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
f4e3917 to
f53ab2d
Compare
…d back data synchronization
npolina4
reviewed
Jul 9, 2024
npolina4
approved these changes
Jul 9, 2024
vtavana
approved these changes
Jul 9, 2024
github-actions bot
added a commit
that referenced
this pull request
Jul 10, 2024
#1913) * Remove limitations from dpnp.take implementation * Add more test to cover specail cases and increase code coverage * Applied pre-commit hook * Corrected test_over_index * Update docsctrings with resolving typos * Use dpnp.reshape() to change shape and create dpnp array from usm_ndarray result * Remove limitations from dpnp.place implementation * Update relating tests * Roll back changed in dpnp.vander * Remove data sync at the end of function * Update indexing functions * Add missing test scenario * Updated docstring in put_along_axis() and take_along_axis() and rolled back data synchronization * Remove data synchronization for dpnp.put() * Remove data synchronization for dpnp.nonzero() * Remove data synchronization for dpnp.indices() * Remove data synchronization for dpnp.extract() * Remove data sync in dpnp.get_result_array() f19e989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates docstring documentation of indexing functions, resolving some typos and completing the description with missing information.
Another improvements implementing in scope of that PR is to avoid unnecessary casting to dpnp array if it is required to manipulate with
usm_ndarrayonly.