Adding pylint pre-commit hook #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
349d86c to
27c9e3c
Compare
…ce_searching.py dpnp_iface_sorting.py dpnp_iface_statistics.py dpnp_iface_types.py
vlad-perevezentsev
approved these changes
Feb 20, 2024
Contributor
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM!
Thank you @antonwolfy for adding a useful pre-commit hook
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Feb 20, 2024
* Resolved all issue in dpnp_iface.py * Make pylint as a local hook * Added dpnp_iface_arraycreation.py to the pylint hook * Added dpnp_iface_counting.py and dpnp_iface_indexing.py * Added dpnp_iface_libmath.py and dpnp_iface_linearalgebra.py * Adding dpnp_iface_manipulation.py dpnp_iface_nanfunctions.py dpnp_iface_searching.py dpnp_iface_sorting.py dpnp_iface_statistics.py dpnp_iface_types.py * Disable D205 flake8 warning globally e6e7b3e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR extends pre-commit hooks with
pylintconfiguration.The current files filter for the verification is set to
dpnp/dpnp_iface*.py(excluding files from #1712) to reduce number of issues. The other files will be added to the scope in later PRs