Implemented nin and nout property for elementwise functions #1712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
@npolina4 , could you please add a detailed description to the PR? |
antonwolfy
reviewed
Feb 16, 2024
antonwolfy
reviewed
Feb 16, 2024
antonwolfy
reviewed
Feb 16, 2024
6 tasks
antonwolfy
reviewed
Feb 21, 2024
Contributor
|
Does the absence of the function signature in the documentation align with our intentions with the new approach?
|
antonwolfy
reviewed
Mar 24, 2024
antonwolfy
reviewed
Mar 27, 2024
antonwolfy
reviewed
Mar 27, 2024
antonwolfy
approved these changes
Apr 2, 2024
Contributor
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @npolina4 , I have only minor comment.
antonwolfy
reviewed
Apr 9, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 10, 2024
* Implemented nin and nout property for elementwise functions * address comments * Apply pylint * fix tests * Deleted debugging print * Added TypeError for functions that do not support bool dtype * fix typo * Fixed docstrings for element-wise functions * Remove call_origin for element-wise functions * address comments * Update dpnp_elementwise_common.py * Fix linalg tests. Fix element-wise docs * address comments * Fix tests for Iris Xe * Improve code coverage * Update dpnp/dpnp_algo/dpnp_elementwise_common.py Co-authored-by: Anton <[email protected]> * fix pre-commit * fix typo * Added missing call to _mkl_round_to_call --------- Co-authored-by: Anton <[email protected]> 240b14f
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Apr 10, 2024
…hon#1712) * Implemented nin and nout property for elementwise functions * address comments * Apply pylint * fix tests * Deleted debugging print * Added TypeError for functions that do not support bool dtype * fix typo * Fixed docstrings for element-wise functions * Remove call_origin for element-wise functions * address comments * Update dpnp_elementwise_common.py * Fix linalg tests. Fix element-wise docs * address comments * Fix tests for Iris Xe * Improve code coverage * Update dpnp/dpnp_algo/dpnp_elementwise_common.py Co-authored-by: Anton <[email protected]> * fix pre-commit * fix typo * Added missing call to _mkl_round_to_call --------- Co-authored-by: Anton <[email protected]> 240b14f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reused
dpctl.tensor.BinaryElementwiseFuncanddpctl.tensor.UnaryElementwiseFuncclasses forDPNPBinaryFuncandDPNPUnaryFuncfor using nin and nout property.Added special classes for
dpnp.angle,dpnp.real,dpnp.round, anddpnp.signbecause thesedpctl.tensorfunctions has different behavior compared tonumpyfunctions.Updated all elementwise functions with using new classes.
Updated docs for elementwise functions. Added descriptions for input args.
Added tests.