Skip to content

5.0.0 - Upgrade DCL to 1.52#9055

Merged
c2thorn merged 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0from
c2thorn:5.0.0-dcl
Sep 25, 2023
Merged

5.0.0 - Upgrade DCL to 1.52#9055
c2thorn merged 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0from
c2thorn:5.0.0-dcl

Conversation

@c2thorn

@c2thorn c2thorn commented Sep 22, 2023

Copy link
Copy Markdown
Member

fixes hashicorp/terraform-provider-google#15497

upgrade guide: #8636

Release Note Template for Downstream PRs (will be copied)

firebase: made `google_firebase_rules.release` immutable
containeraws: added `binary_authorization` to `google_container_aws_cluster`
containeraws: added `update_settings` to `google_container_aws_node_pool`

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 151 insertions(+), 126 deletions(-))
Terraform Beta: Diff ( 12 files changed, 283 insertions(+), 130 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3082
Passed tests 2766
Skipped tests: 314
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerNodePool_withSandboxConfig|TestAccContainerAwsCluster_BetaBasicEnumHandWritten

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_withSandboxConfig[Debug log]
TestAccContainerAwsCluster_BetaBasicEnumHandWritten[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@c2thorn c2thorn requested a review from NickElliot September 25, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants