Add migration guide for google_firebaserules_release breaking changes#8636
Merged
c2thorn merged 1 commit intoAug 14, 2023
Merged
Conversation
Collaborator
|
Hello! I am a robot. It looks like you are a: @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
8da28db to
47112ee
Compare
Collaborator
Member
|
@rainshen49 , should @c2thorn be added as the reviewer? Thanks. |
Contributor
Author
|
@zli82016 Yes. I don't have the permission to configure my own reviewers. |
Member
|
Added @c2thorn as the reviewer. |
Member
|
Hi, @rainshen49, I created hashicorp/terraform-provider-google#15497 to track the DCL change |
DanielRieske
pushed a commit
to DanielRieske/magic-modules
that referenced
this pull request
Aug 15, 2023
nevzheng
pushed a commit
to nevzheng/magic-modules
that referenced
this pull request
Aug 16, 2023
rainshen49
added a commit
to rainshen49/magic-modules
that referenced
this pull request
Aug 21, 2023
joelkattapuram
pushed a commit
to joelkattapuram/magic-modules
that referenced
this pull request
Sep 20, 2023
This was referenced Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To maintainers: please add c2thorn as a reviewer because he is coordinating other parts of this change with DCL.
Fixes hashicorp/terraform-provider-google#13235
If this PR is for Terraform, I acknowledge that I have:
Release Note Template for Downstream PRs (will be copied)