Skip to content

Add migration guide for google_firebaserules_release breaking changes#8636

Merged
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
rainshen49:firebaserules-immutable
Aug 14, 2023
Merged

Add migration guide for google_firebaserules_release breaking changes#8636
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
rainshen49:firebaserules-immutable

Conversation

@rainshen49

@rainshen49 rainshen49 commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

To maintainers: please add c2thorn as a reviewer because he is coordinating other parts of this change with DCL.

Fixes hashicorp/terraform-provider-google#13235

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

docs: added the breaking change of the resource `google_firebaserules_release` to the 5.0.0 guides

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@rainshen49 rainshen49 force-pushed the firebaserules-immutable branch from 8da28db to 47112ee Compare August 14, 2023 18:50
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 54 insertions(+))
Terraform Beta: Diff ( 1 file changed, 54 insertions(+))

@zli82016

Copy link
Copy Markdown
Member

@rainshen49 , should @c2thorn be added as the reviewer? Thanks.

@rainshen49

Copy link
Copy Markdown
Contributor Author

@zli82016 Yes. I don't have the permission to configure my own reviewers.

@zli82016 zli82016 requested a review from c2thorn August 14, 2023 20:22
@zli82016

Copy link
Copy Markdown
Member

Added @c2thorn as the reviewer.

@zli82016 zli82016 removed their request for review August 14, 2023 20:23

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@c2thorn

c2thorn commented Aug 14, 2023

Copy link
Copy Markdown
Member

Hi, @rainshen49, I created hashicorp/terraform-provider-google#15497 to track the DCL change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Truely declarative Firebase security rules management

4 participants