Skip to content

Upgrade guide - container nodepool#8969

Merged
c2thorn merged 2 commits into
GoogleCloudPlatform:mainfrom
c2thorn:5.0.0-nodepool-guide
Sep 21, 2023
Merged

Upgrade guide - container nodepool#8969
c2thorn merged 2 commits into
GoogleCloudPlatform:mainfrom
c2thorn:5.0.0-nodepool-guide

Conversation

@c2thorn

@c2thorn c2thorn commented Sep 15, 2023

Copy link
Copy Markdown
Member

guide for #8967

@c2thorn c2thorn mentioned this pull request Sep 15, 2023
Merged
5 tasks
@modular-magician

modular-magician commented Sep 15, 2023

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 10 insertions(+))
Terraform Beta: Diff ( 1 file changed, 10 insertions(+))

toVersus
toVersus reviewed Sep 17, 2023
View reviewed changes
Comment thread mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
c2thorn and others added 2 commits September 21, 2023 11:05
@c2thorn
Upgrade guide - container nodepool
8c6647d
@c2thorn @toVersus
Update mmv1/third_party/terraform/website/docs/guides/version_5_upgra…
50dc45e 
…de.html.markdown

Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
@c2thorn c2thorn force-pushed the 5.0.0-nodepool-guide branch from 067eef7 to 50dc45e Compare September 21, 2023 16:05
@c2thorn c2thorn requested a review from slevenick September 21, 2023 16:05
@modular-magician

modular-magician commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 14 insertions(+))
Terraform Beta: Diff ( 1 file changed, 14 insertions(+))

@c2thorn c2thorn merged commit c68c0c0 into GoogleCloudPlatform:main Sep 21, 2023
This was referenced Sep 21, 2023
Merged
Merged
Merged
Merged
Merged
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Sep 22, 2023
@c2thorn @nevzheng
Upgrade guide - container nodepool (GoogleCloudPlatform#8969)
fc71511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slevenick slevenick slevenick approved these changes

+1 more reviewer

@toVersus toVersus toVersus left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@c2thorn @modular-magician @slevenick @toVersus