Change container node pool defaults

[c2thorn]

fixes hashicorp/terraform-provider-google#6236

fixes hashicorp/terraform-provider-google#13706

both auto repair and auto upgrade default to true according to these docs and verified in testing
https://cloud.google.com/kubernetes-engine/docs/how-to/node-auto-repair
https://cloud.google.com/kubernetes-engine/docs/how-to/node-auto-upgrades

upgrade guide: #8969

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: removed default for `logging_variant` in `google_container_node_pool`

container: changed `management.auto_repair` and `management.auto_upgrade` defaults to true in `google_container_node_pool`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field management.auto_repair default value changed from false to true on google_container_node_pool - reference
• Field management.auto_upgrade default value changed from false to true on google_container_node_pool - reference
• Field node_config.logging_variant default value changed from DEFAULT to on google_container_cluster - reference
• Field node_config.logging_variant default value changed from DEFAULT to on google_container_node_pool - reference
• Field node_pool.management.auto_repair default value changed from false to true on google_container_cluster - reference
• Field node_pool.management.auto_upgrade default value changed from false to true on google_container_cluster - reference
• Field node_pool.node_config.logging_variant default value changed from DEFAULT to on google_container_cluster - reference
• Field node_pool_defaults.node_config_defaults.logging_variant default value changed from DEFAULT to on google_container_cluster - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3036
Passed tests 2690
Skipped tests: 304
Affected tests: 42

Action taken

Found 42 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withNodeConfigReservationAffinity|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withILBSubsetting|TestAccContainerNodePool_withHostMaintenancePolicy|TestAccContainerNodePool_withConfidentialNodes|TestAccContainerNodePool_threadsPerCore|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_customPlacementPolicy|TestAccContainerCluster_withNodeConfigReservationAffinitySpecific|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withMultiNicNetworkConfig|TestAccContainerNodePool_withEnablePrivateNodesToggle|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withReservationAffinity|TestAccContainerNodePool_withSandboxConfig|TestAccContainerCluster_customPlacementPolicy|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_compactPlacement|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerNodePool_gvnic|TestAccContainerNodePool_ephemeralStorageLocalSsdConfig|TestAccContainerNodePool_localNvmeSsdBlockConfig|TestAccContainerCluster_withNodeConfig|TestAccContainerNodePool_withNetworkConfig|TestAccContainerCluster_withNodePoolDefaults|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerCluster_backend|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withWorkloadMetadataConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withNodeConfigReservationAffinity[Debug log]
TestAccContainerCluster_withConfidentialNodes[Debug log]
TestAccContainerCluster_withILBSubsetting[Debug log]
TestAccContainerNodePool_withHostMaintenancePolicy[Debug log]
TestAccContainerNodePool_withConfidentialNodes[Debug log]
TestAccContainerNodePool_threadsPerCore[Debug log]
TestAccContainerCluster_withSoleTenantGroup[Debug log]
TestAccContainerNodePool_012_ConfigModeAttr[Debug log]
TestAccContainerNodePool_customPlacementPolicy[Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinitySpecific[Debug log]
TestAccContainerNodePool_withSoleTenantConfig[Debug log]
TestAccContainerNodePool_withLinuxNodeConfig[Debug log]
TestAccContainerNodePool_shieldedInstanceConfig[Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator[Debug log]
TestAccContainerNodePool_withNodeConfigScopeAlias[Debug log]
TestAccContainerNodePool_withManagement[Debug log]
TestAccContainerNodePool_withGPU[Debug log]
TestAccContainerNodePool_withMultiNicNetworkConfig[Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle[Debug log]
TestAccContainerNodePool_withNodeConfig[Debug log]
TestAccContainerNodePool_withReservationAffinitySpecific[Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig[Debug log]
TestAccContainerNodePool_withReservationAffinity[Debug log]
TestAccContainerNodePool_withSandboxConfig[Debug log]
TestAccContainerCluster_customPlacementPolicy[Debug log]
TestAccContainerNodePool_gcfsConfig[Debug log]
TestAccContainerNodePool_compactPlacement[Debug log]
TestAccContainerCluster_withNodeConfigShieldedInstanceConfig[Debug log]
TestAccContainerCluster_withNodeConfigScopeAlias[Debug log]
TestAccContainerNodePool_gvnic[Debug log]
TestAccContainerNodePool_ephemeralStorageLocalSsdConfig[Debug log]
TestAccContainerNodePool_localNvmeSsdBlockConfig[Debug log]
TestAccContainerCluster_withNodeConfig[Debug log]
TestAccContainerNodePool_withNetworkConfig[Debug log]
TestAccContainerCluster_withNodePoolDefaults[Debug log]
TestAccContainerCluster_withNodePoolNodeConfig[Debug log]
TestAccContainerNodePool_ephemeralStorageConfig[Debug log]
TestAccContainerCluster_backend[Debug log]
TestAccContainerCluster_withBootDiskKmsKey[Debug log]
TestAccContainerCluster_withSandboxConfig[Debug log]
TestAccContainerCluster_withWorkloadMetadataConfig[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field management.auto_repair default value changed from false to true on google_container_node_pool - reference
• Field management.auto_upgrade default value changed from false to true on google_container_node_pool - reference
• Field node_config.logging_variant default value changed from DEFAULT to on google_container_cluster - reference
• Field node_config.logging_variant default value changed from DEFAULT to on google_container_node_pool - reference
• Field node_pool.management.auto_repair default value changed from false to true on google_container_cluster - reference
• Field node_pool.management.auto_upgrade default value changed from false to true on google_container_cluster - reference
• Field node_pool.node_config.logging_variant default value changed from DEFAULT to on google_container_cluster - reference
• Field node_pool_defaults.node_config_defaults.logging_variant default value changed from DEFAULT to on google_container_cluster - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 11 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 4 files changed, 11 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3035
Passed tests 2729
Skipped tests: 304
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withKubeletConfig|TestAccVertexAIIndexEndpoint_updated

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field management.auto_repair default value changed from false to true on google_container_node_pool - reference
• Field management.auto_upgrade default value changed from false to true on google_container_node_pool - reference
• Field node_config.logging_variant default value changed from DEFAULT to on google_container_cluster - reference
• Field node_config.logging_variant default value changed from DEFAULT to on google_container_node_pool - reference
• Field node_pool.management.auto_repair default value changed from false to true on google_container_cluster - reference
• Field node_pool.management.auto_upgrade default value changed from false to true on google_container_cluster - reference
• Field node_pool.node_config.logging_variant default value changed from DEFAULT to on google_container_cluster - reference
• Field node_pool_defaults.node_config_defaults.logging_variant default value changed from DEFAULT to on google_container_cluster - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 8 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 4 files changed, 8 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3068
Passed tests 2758
Skipped tests: 307
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccContainerNodePool_fastSocket|TestAccVertexAIIndexEndpoint_updated

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_fastSocket[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log]
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[slevenick]

I assume we have a bunch of tests where this is not set, so we don't need to add one?

[c2thorn]

Yes, the majority of tests do not have this set