Remove deprecated fields from Cloud Run v2 resources#8529
Conversation
|
Hello! I am a robot. It looks like you are a community contributor. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 121 insertions(+), 1192 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceTCPProbesUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceProbesExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
melinath
left a comment
There was a problem hiding this comment.
Please add multiple release note blocks since this impacts multiple resources - see https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/ for more details.
done |
There was a problem hiding this comment.
LGTM - please be sure to add a note about this change to https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown on the main branch
a102bc6
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
|
Hi @yanweiguo, if you haven't already, can you add an upgrade guide entry to the main branch here: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown It should describe the breaking change and any manual steps user's will need to do as they upgrade. Examples are in registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_4_upgrade |
Will do. |
Fixes hashicorp/terraform-provider-google#13506.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)