remove deprecated fields from Cloud Run v2 resources#8522
Conversation
|
Hello! I am a robot. It looks like you are a community contributor. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 121 insertions(+), 1192 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceTCPProbesUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceProbesExample |
|
Rerun these tests in REPLAYING mode to catch issues$\textcolor{green}{\textsf{All tests passed!}} |
There was a problem hiding this comment.
Hey! As this is a breaking change intended for the next major release, it needs to opened as a PR against the 5.0.0 branch following the instructions here: https://googlecloudplatform.github.io/magic-modules/develop/make-a-breaking-change/#contributing-to-the-next-major-release-500
Thanks for the information. Closed this in favor of #8529 |
Fixes hashicorp/terraform-provider-google#13506.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)