Enhance BigQuery table schema input validation

[wj-chen]

Fixes hashicorp/terraform-provider-google#14659.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

added more input validations for BigQuery table schema

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• added more input validations for BigQuery table schema

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @hao-nan-li, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 160 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 160 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2789
Passed tests 2489
Skipped tests: 296
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_multipleRules|TestAccBigQueryExternalDataTable_CSV_WithSchema_InvalidSchemas|TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccBigQueryTable_invalidSchemas

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccBigQueryExternalDataTable_CSV_WithSchema_InvalidSchemas[Debug log]
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]
TestAccBigQueryTable_invalidSchemas[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[hao-nan-li]

Thanks for updating the validation function. Just have one question regarding the JSON list.

[hao-nan-li]

Looks like the contribution window for our major release started today. Instructions are published https://googlecloudplatform.github.io/magic-modules/develop/make-a-breaking-change/#making-a-breaking-change

[wj-chen]

Looks like the contribution window for our major release started today. Instructions are published https://googlecloudplatform.github.io/magic-modules/develop/make-a-breaking-change/#making-a-breaking-change

Thank you very much for sharing! I will go through it this week.

[wj-chen]

Looks like the contribution window for our major release started today. Instructions are published https://googlecloudplatform.github.io/magic-modules/develop/make-a-breaking-change/#making-a-breaking-change

Thank you very much for sharing! I will go through it this week.

I took a very quick look - If I plan to cherry-pick this commit into the 5.0-feature branch, does that mean opening another separate PR?

[hao-nan-li]

Looks like the contribution window for our major release started today. Instructions are published https://googlecloudplatform.github.io/magic-modules/develop/make-a-breaking-change/#making-a-breaking-change

Thank you very much for sharing! I will go through it this week.

I took a very quick look - If I plan to cherry-pick this commit into the 5.0-feature branch, does that mean opening another separate PR?

I think yeah, open another PR and target the 5.0-feature branch.

[wj-chen]

added more input validations for BigQuery table schema

Here is the new PR with this change cherry-picked into FEATURE-BRANCH-major-release-5.0.0: #8460

[wj-chen]

THank you very much for the approval in #8460! Do I need to update this PR (to include VCR skip) to get it ready for the main branch?

[hao-nan-li]

THank you very much for the approval in #8460! Do I need to update this PR (to include VCR skip) to get it ready for the main branch?

I think we can close this, during the next major release the other PR will be merged to main.

[wj-chen]

THank you very much for the approval in #8460! Do I need to update this PR (to include VCR skip) to get it ready for the main branch?

I think we can close this, during the next major release the other PR will be merged to main.

Great! Thank you again for all the help!