Skip to content

Enhance BigQuery table schema input validation#8136

Closed
wj-chen wants to merge 0 commit into
GoogleCloudPlatform:mainfrom
wj-chen:issue14659
Closed

Enhance BigQuery table schema input validation#8136
wj-chen wants to merge 0 commit into
GoogleCloudPlatform:mainfrom
wj-chen:issue14659

Conversation

@wj-chen

@wj-chen wj-chen commented Jun 12, 2023

Copy link
Copy Markdown
Member

Fixes hashicorp/terraform-provider-google#14659.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

added more input validations for BigQuery table schema

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @hao-nan-li, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 161 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 161 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2787
Passed tests 2487
Skipped tests: 295
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccBigQueryExternalDataTable_CSV_WithSchema_InvalidSchemas|TestAccBigQueryTable_invalidSchemas|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests passed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchema_InvalidSchemas[Debug log]
TestAccBigQueryTable_invalidSchemas[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@hao-nan-li hao-nan-li left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some git conflicts, you may need to do a rebase.

@wj-chen wj-chen closed this Jun 13, 2023
@wj-chen wj-chen force-pushed the issue14659 branch 2 times, most recently from fc3ccb8 to b2e3540 Compare June 13, 2023 17:22
@wj-chen

wj-chen commented Jun 13, 2023

Copy link
Copy Markdown
Member Author

This PR was dropped when I attempted to do a sync with the remote repo. New one opened at 8145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_bigquery_table: Terraform Provider Plugin Crashed terraform-provider-google_v4.65.2_x5 (and other versions)

3 participants